82182[TASK] Use array for controller action lists
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Nikita Hovratov +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Nikita Hovratov +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/ext_localconf.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/ext_localconf.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+20 −20
- typo3/sysext/felogin/ext_localconf.php+4 −4
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/ext_localconf.php+1 −3
- typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/ext_localconf.php+6 −6
- typo3/sysext/form/ext_localconf.php+2 −2
- typo3/sysext/indexed_search/ext_localconf.php+2 −2
Review log 1215
-
Oli Bartsch uploaded patch set 1 12/13/23, 14:04
-
core-ci voted on patch set 1 V -1 12/13/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50622
-
Oli Bartsch commented on patch set 2
V -112/13/23, 14:42Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 12/13/23, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50623
-
Simon Schaufelberger commented on patch set 2 12/14/23, 23:52
To my surprise, I had the exact same patch created some time ago and it got rejected: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71232 -
Simon Schaufelberger commented on patch set 2 12/14/23, 23:55
Reply
The last feedback I got was: The next iteration should work without ext_localconf.php and should be streamlined with the new backend module registration format. We need to get rid of ext_localconf and avoid having extension authors to change stuff in ext_localconf.php again, the only changes should be deletions from that file ;) -
Nikita Hovratov commented on patch set 2 12/15/23, 08:53
Reply
The difference here is, that this is just an internal change. We haven't deprecated the csv syntax. The array syntax will be enforced as soon as we provde a completely new registration API. This change is just for a small performance gain. -
Simon Schaufelberger commented on patch set 2 CR +1 V +1 12/15/23, 09:08
Reply
Acknowledged -
Simon Schaufelberger updated the commit message in patch set 3
CR +1V +112/15/23, 09:08 -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/15/23, 09:09
-
core-ci voted on patch set 3 V +1 12/15/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50672
-
Nikita Hovratov voted on patch set 3 CR +1 V +1 12/16/23, 00:01
-
Garvin Hicking voted on patch set 3 CR +1 V +1 12/16/23, 08:35
-
Oli Bartsch voted on patch set 3 CR +2 V +2 12/18/23, 08:12
-
Oli Bartsch merged patch set 4 12/18/23, 08:12