Review main Merged

82182[TASK] Use array for controller action lists

Oli Bartsch CR +2 V +2 Normal +42 −44 updated 12/18/23, 08:12

Commit message

Clean up plugin configuration by using
an array for the action list. This also
improves performance, since no string
operations have to be done (internally,
TYPO3 handles the action list as array).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Nikita Hovratov +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 1215

  1. Oli Bartsch uploaded patch set 1 12/13/23, 14:04

  2. core-ci voted on patch set 1 V -1 12/13/23, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50622

  3. Oli Bartsch commented on patch set 2 V -1 12/13/23, 14:42

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 12/13/23, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50623

  5. Simon Schaufelberger commented on patch set 2 12/14/23, 23:52

    To my surprise, I had the exact same patch created some time ago and it got rejected: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71232
  6. Simon Schaufelberger commented on patch set 2 12/14/23, 23:55

    Reply

    The last feedback I got was: The next iteration should work without ext_localconf.php and should be streamlined with the new backend module registration format. We need to get rid of ext_localconf and avoid having extension authors to change stuff in ext_localconf.php again, the only changes should be deletions from that file ;)
  7. Nikita Hovratov commented on patch set 2 12/15/23, 08:53

    Reply

    The difference here is, that this is just an internal change. We haven't deprecated the csv syntax. The array syntax will be enforced as soon as we provde a completely new registration API. This change is just for a small performance gain.
  8. Simon Schaufelberger commented on patch set 2 CR +1 V +1 12/15/23, 09:08

    Reply

    Acknowledged
  9. Simon Schaufelberger updated the commit message in patch set 3 CR +1 V +1 12/15/23, 09:08

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/15/23, 09:09

  11. core-ci voted on patch set 3 V +1 12/15/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50672

  12. Nikita Hovratov voted on patch set 3 CR +1 V +1 12/16/23, 00:01

  13. Garvin Hicking voted on patch set 3 CR +1 V +1 12/16/23, 08:35

  14. Oli Bartsch voted on patch set 3 CR +2 V +2 12/18/23, 08:12

  15. Oli Bartsch merged patch set 4 12/18/23, 08:12