Review main Merged

82185[TASK] Enable tablecaption in CKEditor5

Benjamin Franzke CR +2 V +2 Easy +19 −5 updated 02/17/24, 08:06

Commit message

CKEditor5 renders tablecaptions as figcaption elements,
therefore we allow them to be included in RTE and
in frontend rendering.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1115

  1. Benjamin Franzke uploaded patch set 1 12/14/23, 08:19

  2. core-ci voted on patch set 1 V +1 12/14/23, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50641

  3. Benjamin Franzke uploaded patch set 2 V +1 12/14/23, 08:45

  4. core-ci voted on patch set 2 V +1 12/14/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50642

  5. Oli Bartsch commented on patch set 2 12/15/23, 08:24

    Patch basically works. However, while table caption is added on top of the table in the Editor, it get's rendered below the table in the frontend. This can also be seen in the "Source" view of then editor. Is this correct? I would expect the caption above the table as it's displayed in the editor.
  6. Benjamin Franzke uploaded patch set 3 V +1 02/12/24, 20:45

  7. core-ci voted on patch set 3 V +1 02/12/24, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53102

  8. Benjamin Franzke rebased onto patch set 4 V +1 02/13/24, 13:28

  9. Benni Mack commented on patch set 4 02/13/24, 13:31

    Reply

    This is correct
  10. core-ci voted on patch set 4 V +1 02/13/24, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53174

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 02/13/24, 13:54

  12. Benni Mack voted on patch set 4 CR +1 V +1 02/16/24, 12:16

  13. Guido Schmechel voted on patch set 4 CR +1 V +1 02/16/24, 12:56

  14. Benjamin Franzke voted on patch set 4 CR +2 V +2 02/17/24, 08:06

  15. Benjamin Franzke merged patch set 5 02/17/24, 08:06