Review main Merged

82188[BUGFIX] Add sufficient role and aria attributes

Christian Rath-Ulrich CR +2 V +2 Easy +15 −7 updated 12/18/23, 12:11

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Christian Rath-Ulrich +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Christian Rath-Ulrich +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Christian Rath-Ulrich uploaded patch set 1 12/14/23, 21:37

  2. core-ci voted on patch set 1 V -1 12/14/23, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50661

  3. Christian Rath-Ulrich uploaded patch set 2 V -1 12/14/23, 21:56

  4. core-ci voted on patch set 2 V -1 12/14/23, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50662

  5. Andreas Kienast commented on patch set 2 CR -1 12/15/23, 06:18

    Besides that you have to modify the TypeScript sources and rebuild the modules, is it really safe to potentially have the same IDs multiple times in the DOM? I think we'd need some random string appended.
  6. Andreas Kienast uploaded patch set 3 CR -1 V -1 12/15/23, 06:33

  7. core-ci voted on patch set 3 V +1 12/15/23, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50667

  8. Christian Rath-Ulrich commented on patch set 3 CR +1 V +1 12/15/23, 13:51

    Reply

    yes thats a much better solution
  9. Christian Kuhn voted on patch set 3 CR +1 V +1 12/18/23, 11:05

  10. Oli Bartsch voted on patch set 3 CR +1 V +1 12/18/23, 11:23

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 12/18/23, 12:11

  12. Christian Kuhn merged patch set 4 12/18/23, 12:11