82191[FEATURE] Introduce site sets with setting definitions
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 48
- typo3/sysext/backend/Classes/Configuration/TCA/ItemsProcessorFunctions.php2+12 −0
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+11 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php2+6 −1
- typo3/sysext/backend/Configuration/SiteConfiguration/site.php2+11 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration_tca.xlf2+3 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+5 −0
- typo3/sysext/core/Classes/Command/SiteSetsListCommand.phpnew+74 −0
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php3+3 −29
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php3+37 −0
- typo3/sysext/core/Classes/Settings/Type/BoolType.phpnew+77 −0
- typo3/sysext/core/Classes/Settings/Type/ColorType.phpnew+145 −0
- typo3/sysext/core/Classes/Settings/Type/IntType.phpnew+55 −0
- typo3/sysext/core/Classes/Settings/Type/NumberType.phpnew+67 −0
- typo3/sysext/core/Classes/Settings/Type/StringListType.phpnew+63 −0
- typo3/sysext/core/Classes/Settings/Type/StringType.phpnew+54 −0
- typo3/sysext/core/Classes/Settings/Type/TextType.phpnew+23 −0
- typo3/sysext/core/Classes/Settings/SettingDefinition.php10new+45 −0
- typo3/sysext/core/Classes/Settings/Settings.php2new+51 −0
- typo3/sysext/core/Classes/Settings/SettingsInterface.php2new+32 −0
- typo3/sysext/core/Classes/Settings/SettingsTypeInterface.phpnew+31 −0
Show 28 more files
- typo3/sysext/core/Classes/Settings/SettingsTypeRegistry.php2new+42 −0
- typo3/sysext/core/Classes/Site/Entity/Site.php4+25 −0
- typo3/sysext/core/Classes/Site/Entity/SiteSettings.php+12 −5
- typo3/sysext/core/Classes/Site/Set/InvalidSetException.phpnew+20 −0
- typo3/sysext/core/Classes/Site/Set/SetCollector.phpnew+40 −0
- typo3/sysext/core/Classes/Site/Set/SetDefinition.php2new+46 −0
- typo3/sysext/core/Classes/Site/Set/SetRegistry.phpnew+154 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php5new+110 −0
- typo3/sysext/core/Classes/Site/SiteSettingsFactory.php2new+138 −0
- typo3/sysext/core/Classes/Site/TcaSiteSetCollector.phpnew+42 −0
- typo3/sysext/core/Configuration/Services.yaml+11 −1
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103437-IntroduceSiteSets.rst10new+119 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidDependency/config.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set1/config.yamlnew+9 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set2/config.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set3/config.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set4/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/Set5/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Site/Set/SetRegistryTest.phpnew+86 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+10 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/BoolTypeTest.phpnew+97 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/ColorTypeTest.phpnew+100 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/IntTypeTest.phpnew+97 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/NumberTypeTest.phpnew+99 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/StringListTypeTest.phpnew+120 −0
- typo3/sysext/core/Tests/Unit/Settings/Type/StringTypeTest.phpnew+106 −0
Review log 76119
Show 5694 earlier messages
-
Benjamin Franzke uploaded patch set 1 12/15/23, 10:11
-
core-ci voted on patch set 1 V -1 12/15/23, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50676
-
Benjamin Franzke uploaded patch set 2
V -112/15/23, 12:38 -
core-ci voted on patch set 2 V -1 12/15/23, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50694
-
Benjamin Franzke uploaded patch set 3
V -101/12/24, 10:16 -
core-ci voted on patch set 3 V -1 01/12/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51490
-
Benjamin Franzke uploaded patch set 4
V -103/12/24, 06:41 -
core-ci voted on patch set 4 V -1 03/12/24, 06:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54393
-
Benjamin Franzke uploaded patch set 5
V -103/15/24, 08:13 -
core-ci voted on patch set 5 V -1 03/15/24, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54567
-
Benjamin Franzke uploaded patch set 6
V -103/15/24, 09:12 -
core-ci voted on patch set 6 V -1 03/15/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54572
-
Benjamin Franzke uploaded patch set 7
V -103/15/24, 12:55 -
core-ci voted on patch set 7 V -1 03/15/24, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54590
-
Benjamin Franzke uploaded patch set 8
V -103/19/24, 16:10 -
core-ci voted on patch set 8 V -1 03/19/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54704
-
Benjamin Franzke uploaded patch set 9
V -103/19/24, 18:03 -
core-ci voted on patch set 9 V -1 03/19/24, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54705
-
core-ci voted on patch set 9 V +1 03/19/24, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54705
-
Benjamin Franzke uploaded patch set 10
V +103/20/24, 14:41 -
core-ci voted on patch set 10 V +1 03/20/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54723
-
Benjamin Franzke uploaded patch set 11
V +103/20/24, 17:19 -
core-ci voted on patch set 11 V +1 03/20/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54734
-
Benjamin Franzke uploaded patch set 12
V +103/20/24, 19:02 -
core-ci voted on patch set 12 V +1 03/20/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54741
-
Benjamin Franzke uploaded patch set 13
V +103/20/24, 21:12 -
core-ci voted on patch set 13 V +1 03/20/24, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54748
-
Benni Mack commented on patch set 13 03/20/24, 22:39
SiteSettingsFactory.php:52can be injected via DI -
Benjamin Franzke uploaded patch set 14
V +103/21/24, 07:40 -
Benjamin Franzke commented on patch set 14 03/21/24, 07:40
SiteConfiguration.php:286Replyack, will need some proper thought in order to not break `typo3/sysext/install/Classes/Updates/MigrateSiteSettingsConfigUpdate.php` for installations that upgrade from v11 to v13 directly.SiteSettingsFactory.php:52Replyack (copied without properly thinking about this), done. -
core-ci voted on patch set 14 V -1 03/21/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54764
-
Benjamin Franzke uploaded patch set 15
V -103/21/24, 07:52 -
core-ci voted on patch set 15 V -1 03/21/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54767
-
Benjamin Franzke uploaded patch set 16
V -103/21/24, 08:09 -
core-ci voted on patch set 16 V +1 03/21/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54770
-
Benjamin Franzke uploaded patch set 17
V +103/21/24, 12:44 -
core-ci voted on patch set 17 V -1 03/21/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54786
-
Benjamin Franzke uploaded patch set 18
V -103/21/24, 13:12 -
Benjamin Franzke commented on patch set 18 03/21/24, 13:15
SiteConfiguration.php:286ReplyMoved into a separate service in a pre-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83557 I think it is fine to keep the logic for how to write site-settings in Site scope, therefore it's fine to be in `SiteWriter` as a dumb persister for now. Any logic on top will be added to other services, to keep the just-write from config.yaml to settings.yaml logic of `MigrateSiteSettingsConfigUpdate` intact. -
core-ci voted on patch set 18 V -1 03/21/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54793
-
Benjamin Franzke uploaded patch set 19
V -103/21/24, 13:58 -
core-ci voted on patch set 19 V +1 03/21/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54801
-
Benjamin Franzke uploaded patch set 20
V +103/22/24, 07:00 -
Benjamin Franzke uploaded patch set 21 03/25/24, 09:18
-
core-ci voted on patch set 21 V -1 03/25/24, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54917
-
Benjamin Franzke uploaded patch set 22
V -103/25/24, 09:34 -
core-ci voted on patch set 22 V +1 03/25/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54919
-
Benjamin Franzke uploaded patch set 23
V +103/28/24, 15:54 -
core-ci voted on patch set 23 V -1 03/28/24, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55031
-
Benjamin Franzke uploaded patch set 24
V -103/28/24, 16:44 -
core-ci voted on patch set 24 V +1 03/28/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55036
-
Benjamin Franzke uploaded patch set 25
V +104/02/24, 12:17 -
core-ci voted on patch set 25 V +1 04/02/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55159
-
Benjamin Franzke uploaded patch set 26
V +104/02/24, 13:23 -
core-ci voted on patch set 26 V +1 04/02/24, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55166
-
Benjamin Franzke updated the commit message in patch set 27
V +104/02/24, 13:46 -
core-ci voted on patch set 27 V +1 04/02/24, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55170
-
Benjamin Franzke uploaded patch set 28
V +104/02/24, 14:00 -
core-ci voted on patch set 28 V +1 04/02/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55176
-
Chris Müller commented on patch set 28 04/02/24, 16:14
I have some questions for better understanding. Maybe the changelog can be clarified, if necessary.Feature-103437-IntroduceSiteProfilesSettings.rst:18What does this mean, that a new rendering context is created? In general, and for me as a integrator.Feature-103437-IntroduceSiteProfilesSettings.rst:29Is "MyProfile" required to be named that way or can I choose it? I assume the later, as it correlates with the label below?Feature-103437-IntroduceSiteProfilesSettings.rst:45When I understand correctly, the settings definition is used, when I ship settings in my (3rd-party) extension with sane defaults. The settings can then be used to override a default setting value with a custom value in a project's installation?Feature-103437-IntroduceSiteProfilesSettings.rst:56What impact does this settings have? I assume, there will be some GUI (later?) where this is displayed?Feature-103437-IntroduceSiteProfilesSettings.rst:66Currently, the difference here between "default settings" and "default values" is unclear to me. -
Benjamin Franzke marked it work in progress 04/02/24, 16:18
-
Benjamin Franzke commented on patch set 28 04/02/24, 16:25
ProfileRegistry.php:92This'll receive functionals tomorrowSettingsInterface.php:20all Settings api's will be marked `@internal` for now, as the upcoming patches – e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/83623 – may need to perform changes. Specific tests for edge cases will then be added, once we have consensus on the interface. For now styleguide acts as acceptance testbed: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83526SettingsTypeRegistry.php:24will be dropped. Using this as a TODO collector for missing types: * `stringlist` (e.g. `['foo', 'bar']`) * some kind of `orderedlist`? (=indexed array) {10: 'EXT:foo/bar…) * `float` (or `number`?) -
Benjamin Franzke commented on patch set 28 04/03/24, 07:26
Feature-103437-IntroduceSiteProfilesSettings.rst:29Needs to be fixed to: `Configuration/Profiles/MyProfile` -
Benjamin Franzke uploaded patch set 29
V +104/03/24, 08:04 -
Benjamin Franzke commented on patch set 29 04/03/24, 08:04
Reply
Thanks for your comments. I tried to rephrase, but it's not final yet. I actually removed the WIP flag by accident – I wasn't finished with this patch at all. …but it turns out it's not too bad to receive early feedback :) To be transparent: We're not even sold on the name "profile" yet, as some say it does not explain/fit-to what it provides.ProfileRegistry.php:92ReplyDoneSettingsInterface.php:20ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:18ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:29ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:29ReplyA random name, tried to clarify that.Feature-103437-IntroduceSiteProfilesSettings.rst:45Replyack, or to set setting for a profile that your profile depends on.Feature-103437-IntroduceSiteProfilesSettings.rst:56ReplyYes, that's what is planned to be done. We want a GUI where settings can be applied to a site (stored in config/sites/*/settings.yaml) based on the profile's that are activated for that site. (Profile settings inside profiles are to be set manually)Feature-103437-IntroduceSiteProfilesSettings.rst:66ReplyTried to reword. -
core-ci voted on patch set 29 V -1 04/03/24, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55209
-
Benjamin Franzke uploaded patch set 30
V -104/03/24, 08:17 -
core-ci voted on patch set 30 V +1 04/03/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55210
-
Benjamin Franzke uploaded patch set 31
V +104/03/24, 08:49 -
core-ci voted on patch set 31 V -1 04/03/24, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55211
-
Benjamin Franzke uploaded patch set 32
V -104/03/24, 09:03 -
core-ci voted on patch set 32 V +1 04/03/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55212
-
Benjamin Franzke commented on patch set 32 04/03/24, 14:10
AbstractServiceProvider.php:198typoProfileCollector.php:48split into a separate factoryProfileDefinition.php:31dropProfileDefinition.php:32add optionalDependenciesProfileDefinition.php:33drop for nowProfileDefinition.php:37contentBlocksProfileRegistry.php:142typo -
Benjamin Franzke uploaded patch set 33
V +104/03/24, 20:46 -
core-ci voted on patch set 33 V -1 04/03/24, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55276
-
Benjamin Franzke uploaded patch set 34
V -104/03/24, 20:53 -
core-ci voted on patch set 34 V +1 04/03/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55277
-
Benjamin Franzke commented on patch set 34 04/03/24, 21:28
AbstractServiceProvider.php:198ReplyDoneProfileCollector.php:48ReplyDoneProfileDefinition.php:31ReplyDoneProfileDefinition.php:32ReplyDoneProfileDefinition.php:33ReplyDoneProfileDefinition.php:37ReplySkipped for later.ProfileRegistry.php:142ReplyDone -
Benjamin Kott commented on patch set 34 04/04/24, 06:15
This change is ready for review.SettingDefinition.php:36missing: - categories - tagsFeature-103437-IntroduceSiteSets.rst:30should we introduce the casing here again or go all lowercase? -
Benjamin Franzke marked it work in progress 04/04/24, 06:17
-
Benjamin Franzke uploaded patch set 35
V +104/04/24, 06:52 -
Benjamin Franzke commented on patch set 35 04/04/24, 06:52
SettingDefinition.php:36Replyadded, but still need to be evaluated (somewhere).Feature-103437-IntroduceSiteSets.rst:30ReplyI'm fine with lowercase – I actually don't care (and the code doesn't), but yea, we need to decide on a convention that we use in code and docs.. -
core-ci voted on patch set 35 V -1 04/04/24, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55312
-
Benjamin Franzke uploaded patch set 36
V -104/04/24, 07:06 -
core-ci voted on patch set 36 V +1 04/04/24, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55316
-
Chris Müller commented on patch set 36 04/04/24, 17:18
Feature-103437-IntroduceSiteSets.rst:30ReplyI agree with the convention, and speaking for the documentation: I would like to have one spelling, otherwise we have to explain to the user, why some folder names must be PascalCase, others can be either PascalCase or lowercase/kebap-case - which will be very confusing to our users (and error-prone). So, "Configuration/Sets/MySet/" looks fine for me, also "configuration/sets/my-set/" (also when both are valid and the user can choose) - but using "Configuration/Sets/my-set" or "Configuration/Sets/myset" does no-one really understand (and is confusing). Personally, I don't care which variant we recommend - but I care about **consistency** in the docs. When we go the lowercase/kebap-case way, I am strongly for streamlining all paths in the docs for v13 (with admonitions that both ways are valid, also for backwards compat) - and this will be then the **recommendation** for folder names in extensions. IMHO, this then also has to be adjusted for: "classes/DataHandling/MyDataHandler.php" or "resources/private/language/locallang.xlf". -
Oli Bartsch commented on patch set 36 04/04/24, 17:29
This change is ready for review.ItemsProcessorFunctions.php:130$label is not nullable AFAICSSiteDatabaseEditRow.php:95I suggest to ensure that $configuration['dependencies'] is an array.site.php:72Can be left out I thinklocallang_siteconfiguration_tca.xlf:25I suggest to omit the "Select"SettingDefinition.php:23can be readonlySettingDefinition.php:32Why nullable?SettingDefinition.php:35Why nullable?Settings.php:23can be readonlySite.php:76protected array $sets;SetDefinition.php:22can be readonlyYamlSetDefinitionProvider.php:82What about allowing settings.*.yaml? So its possible to add separat files, e.g. "settings.styles.yaml" or "settings.tx_news.yaml", while "settings.definitions.yaml" is a special case, already resolved beforehand.Feature-103437-IntroduceSiteSets.rst:33Isn't this more an `identifier`?Feature-103437-IntroduceSiteSets.rst:64Does this represent any hierarchy? Shouldn't this for consistency also be declared as `name` or `identifier`? -
Garvin Hicking commented on patch set 36 04/04/24, 17:37
Feature-103437-IntroduceSiteSets.rst:30ReplyPersonal oppinion: It was a long way to establish uppercasing. I think reverting a recommendation to go lowecase will be confusing. Allowing every directory to be either lower or uppercased can have a performance impact due to double I/O filestat lookups. I'd vote for keeping UpperCamelCase as the recommendation. IMO this really needs a global decission and not creep into specific features. Then we'll have extensions using mixtures of casing and it'll go a kraut-and-rüben-style. /soapbox -
Benjamin Franzke marked it work in progress 04/04/24, 18:50
-
Benjamin Franzke uploaded patch set 37
V +104/05/24, 08:45 -
Benjamin Franzke commented on patch set 37 04/05/24, 08:45
ItemsProcessorFunctions.php:130Replythanks, good catch, was changed in recents patchsets to be not nullable.SiteDatabaseEditRow.php:95ReplyDonesite.php:72ReplyDonelocallang_siteconfiguration_tca.xlf:25Replyack, fits better to the other labels 👍SettingDefinition.php:23ReplyDoneSettingDefinition.php:32ReplyRemovedSettingDefinition.php:35ReplyRemovedSettings.php:23ReplyDoneSite.php:76ReplyDoneSetDefinition.php:22ReplyDoneYamlSetDefinitionProvider.php:82ReplyWouldn't do that for now to be honest, no particular reason, just unneeded overhead IMO.Feature-103437-IntroduceSiteSets.rst:33Reply`identifier` would be fine as well, but I chose `name` on purpose to match the field used by `composer.json` and `package.json` as well. Hope it's fine for you if I resolve this one immediately.Feature-103437-IntroduceSiteSets.rst:64ReplyThe idea is to use a flat structure here. And we don't want sometime like two identifiers. This represents the hierarchy for the object-storage. UI hierarchy will be represented via `category`. (As our settings are "more" nested that we'd like the UI to be.) -
core-ci voted on patch set 37 V +1 04/05/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55373
-
Benjamin Franzke uploaded patch set 38
V +104/05/24, 15:08 -
core-ci voted on patch set 38 V -1 04/05/24, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55391
-
Benjamin Franzke uploaded patch set 39
V -104/05/24, 20:39 -
core-ci voted on patch set 39 V +1 04/05/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55395
-
Benjamin Franzke uploaded patch set 40
V +104/06/24, 09:02 -
core-ci voted on patch set 40 V +1 04/06/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55428
-
Benjamin Franzke marked it ready for review 04/06/24, 15:01
-
Benjamin Franzke uploaded patch set 41
V +104/06/24, 15:59 -
core-ci voted on patch set 41 V +1 04/06/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55440
-
Benjamin Franzke uploaded patch set 42
V +104/06/24, 16:27 -
core-ci voted on patch set 42 V +1 04/06/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55445
-
Benjamin Kott commented on patch set 42 04/06/24, 19:47
SettingDefinition.php:36ReplyDoneYamlSetDefinitionProvider.php:82Replywe have a mixture here since we already have settings.defitions.yaml that would also follow that scheme. In addition we would have again an undefined state of loading order. it´s already possible if you define a set for these options.Feature-103437-IntroduceSiteSets.rst:64ReplyDone -
Benni Mack commented on patch set 42 04/06/24, 20:05
Site.php:328$this->sets !== [] is faster.YamlSetDefinitionProvider.php:82Replymight be an "idea" which I think we should handle separately (in a further patch) - maybe you want to open a separate ticket for this -
Benjamin Kott commented on patch set 42 04/06/24, 21:01
YamlSetDefinitionProvider.php:82ReplyDone -
Benjamin Franzke uploaded patch set 43
V +104/06/24, 23:40 -
Benjamin Franzke commented on patch set 43 04/06/24, 23:40
Reply
I've splitted the FEATURE into three featurs because the TypoScript part deserves a distinct explanation: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83119 Please note that the details of this API may still change until 13.1 is released, so please wait a bit until you adopt documentation from the Feature.rst (otherwise it may be duplicate work if you need to track future changes to the rst)SettingsTypeRegistry.php:24ReplyDoneSite.php:328Replylol, i actually used that in the next commit as well, but forgot to squash that into the right patch :)Feature-103437-IntroduceSiteProfilesSettings.rst:29ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:45ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:56ReplyDoneFeature-103437-IntroduceSiteProfilesSettings.rst:66ReplyDoneFeature-103437-IntroduceSiteSets.rst:30ReplyWe'll go with this convention for now, but will keep to allow both, as we might introduce all-lowercase at *SOME* point (no concrete plans at all). -
core-ci voted on patch set 43 V +1 04/06/24, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55455
-
Benni Mack voted on patch set 43 CR +1 V +1 04/07/24, 07:03
-
Benjamin Kott commented on patch set 43 CR -1 04/07/24, 08:31
I would prefer if we find a different wording for the new bundles, what about profiles? -
Garvin Hicking commented on patch set 43 04/07/24, 08:58
Reply
"Site-sets settings set" can be a bit of a tongue breaker. ;) I do like profiles, even bundles, maybe collection (kind of associating with FAL/record Collections?)... -
Benjamin Kott voted on patch set 43 CR +1 V +1 04/07/24, 09:11
-
Benjamin Kott commented on patch set 43 04/07/24, 09:12
Reply
Done, was only a joke for the surfcamp -
Oli Bartsch voted on patch set 43 CR +1 V +1 04/07/24, 09:15
-
Benjamin Franzke voted on patch set 43 CR +2 V +2 04/07/24, 09:17
-
Benjamin Franzke merged patch set 44 04/07/24, 09:17
-
Christian Kuhn commented on patch set 43 04/07/24, 09:23
AbstractServiceProvider.php:191Unresolvedthis is cached per package, and is compile-time, right? i'm asking since symfony finder can be quite slow, especially when called often. finder performance was the reason to implement 'native' file finding for @import in new TS parser ... is it worth doing this stuff here 'manually' as well?SettingDefinition.php:23Unresolvedfinal possibly? similar question for various other classes below.
SiteConfiguration.php:286