Review main Merged

82191[FEATURE] Introduce site sets with setting definitions

Benjamin Franzke CR +2 V +2 Expert +2342 −42 updated 04/07/24, 09:23

Commit message

Site sets ship parts of site configuration as composable pieces. They
are intended to deliver settings, TypoScript, TSConfig and reference
enabled content blocks for the scope of a site.

Extensions can provide multiple sets in order to ship presets for
different sites or subsets (think of frameworks) where selected features
are exposed as a subset (example: `typo3/seo-xml-sitemap`).

A set is defined in an extensions subfolder in
:file:`Configuration/Sets/`, for example
:file:`EXT:my_extension/Configuration/Sets/MySet/config.yaml`.

The folder name in :file:`Configuration/Sets/` is arbitrary, significant
is the `name` defined in :file:`config.yaml`. The `name` uses a
`vendor/name` scheme by convention, and *should* use the same vendor as
the containing extension. It may differ if needed for compatibility
reasons (e.g. when sets are moved to other extensions).

TypoScript and PageTS providers will be added in subsequent changes
(#103439, #103522).

Technical notes:

 * Sets whose dependencies can not be fullfilled (are unavailable)
   will log an error in the TYPO3 error log and will be ignored.
   This is to ensure a broken set of one site does not break another
   site, if their dependencies can be resolved.

 * All settings interfaces are marked @internal for now, since they
   may change until v13 LTS. It is planned to remove the @internal
   annotation prior to the LTS release.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 48

Show 28 more files

Review log 76119

Show 5694 earlier messages
  1. Benjamin Franzke uploaded patch set 1 12/15/23, 10:11

  2. core-ci voted on patch set 1 V -1 12/15/23, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50676

  3. Benjamin Franzke uploaded patch set 2 V -1 12/15/23, 12:38

  4. core-ci voted on patch set 2 V -1 12/15/23, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50694

  5. Benjamin Franzke uploaded patch set 3 V -1 01/12/24, 10:16

  6. core-ci voted on patch set 3 V -1 01/12/24, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51490

  7. Benjamin Franzke uploaded patch set 4 V -1 03/12/24, 06:41

  8. core-ci voted on patch set 4 V -1 03/12/24, 06:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54393

  9. Benjamin Franzke uploaded patch set 5 V -1 03/15/24, 08:13

  10. core-ci voted on patch set 5 V -1 03/15/24, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54567

  11. Benjamin Franzke uploaded patch set 6 V -1 03/15/24, 09:12

  12. core-ci voted on patch set 6 V -1 03/15/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54572

  13. Benjamin Franzke uploaded patch set 7 V -1 03/15/24, 12:55

  14. core-ci voted on patch set 7 V -1 03/15/24, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54590

  15. Benjamin Franzke uploaded patch set 8 V -1 03/19/24, 16:10

  16. core-ci voted on patch set 8 V -1 03/19/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54704

  17. Benjamin Franzke uploaded patch set 9 V -1 03/19/24, 18:03

  18. core-ci voted on patch set 9 V -1 03/19/24, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54705

  19. core-ci voted on patch set 9 V +1 03/19/24, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54705

  20. Benjamin Franzke uploaded patch set 10 V +1 03/20/24, 14:41

  21. core-ci voted on patch set 10 V +1 03/20/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54723

  22. Benjamin Franzke uploaded patch set 11 V +1 03/20/24, 17:19

  23. core-ci voted on patch set 11 V +1 03/20/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54734

  24. Benjamin Franzke uploaded patch set 12 V +1 03/20/24, 19:02

  25. core-ci voted on patch set 12 V +1 03/20/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54741

  26. Benjamin Franzke uploaded patch set 13 V +1 03/20/24, 21:12

  27. core-ci voted on patch set 13 V +1 03/20/24, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54748

  28. Benni Mack commented on patch set 13 03/20/24, 22:39

    SiteConfiguration.php:286

    please move directly, the class is marked as internal

    SiteSettingsFactory.php:52

    can be injected via DI
  29. Benjamin Franzke uploaded patch set 14 V +1 03/21/24, 07:40

  30. Benjamin Franzke commented on patch set 14 03/21/24, 07:40

    SiteConfiguration.php:286 Reply

    ack, will need some proper thought in order to not break `typo3/sysext/install/Classes/Updates/MigrateSiteSettingsConfigUpdate.php` for installations that upgrade from v11 to v13 directly.

    SiteSettingsFactory.php:52 Reply

    ack (copied without properly thinking about this), done.
  31. core-ci voted on patch set 14 V -1 03/21/24, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54764

  32. Benjamin Franzke uploaded patch set 15 V -1 03/21/24, 07:52

  33. core-ci voted on patch set 15 V -1 03/21/24, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54767

  34. Benjamin Franzke uploaded patch set 16 V -1 03/21/24, 08:09

  35. core-ci voted on patch set 16 V +1 03/21/24, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54770

  36. Benjamin Franzke uploaded patch set 17 V +1 03/21/24, 12:44

  37. core-ci voted on patch set 17 V -1 03/21/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54786

  38. Benjamin Franzke uploaded patch set 18 V -1 03/21/24, 13:12

  39. Benjamin Franzke commented on patch set 18 03/21/24, 13:15

    SiteConfiguration.php:286 Reply

    Moved into a separate service in a pre-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83557 I think it is fine to keep the logic for how to write site-settings in Site scope, therefore it's fine to be in `SiteWriter` as a dumb persister for now. Any logic on top will be added to other services, to keep the just-write from config.yaml to settings.yaml logic of `MigrateSiteSettingsConfigUpdate` intact.
  40. core-ci voted on patch set 18 V -1 03/21/24, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54793

  41. Benjamin Franzke uploaded patch set 19 V -1 03/21/24, 13:58

  42. core-ci voted on patch set 19 V +1 03/21/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54801

  43. Benjamin Franzke uploaded patch set 20 V +1 03/22/24, 07:00

  44. Benjamin Franzke uploaded patch set 21 03/25/24, 09:18

  45. core-ci voted on patch set 21 V -1 03/25/24, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54917

  46. Benjamin Franzke uploaded patch set 22 V -1 03/25/24, 09:34

  47. core-ci voted on patch set 22 V +1 03/25/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54919

  48. Benjamin Franzke uploaded patch set 23 V +1 03/28/24, 15:54

  49. core-ci voted on patch set 23 V -1 03/28/24, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55031

  50. Benjamin Franzke uploaded patch set 24 V -1 03/28/24, 16:44

  51. core-ci voted on patch set 24 V +1 03/28/24, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55036

  52. Benjamin Franzke uploaded patch set 25 V +1 04/02/24, 12:17

  53. core-ci voted on patch set 25 V +1 04/02/24, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55159

  54. Benjamin Franzke uploaded patch set 26 V +1 04/02/24, 13:23

  55. core-ci voted on patch set 26 V +1 04/02/24, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55166

  56. Benjamin Franzke updated the commit message in patch set 27 V +1 04/02/24, 13:46

  57. core-ci voted on patch set 27 V +1 04/02/24, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55170

  58. Benjamin Franzke uploaded patch set 28 V +1 04/02/24, 14:00

  59. core-ci voted on patch set 28 V +1 04/02/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55176

  60. Chris Müller commented on patch set 28 04/02/24, 16:14

    I have some questions for better understanding. Maybe the changelog can be clarified, if necessary.

    Feature-103437-IntroduceSiteProfilesSettings.rst:18

    What does this mean, that a new rendering context is created? In general, and for me as a integrator.

    Feature-103437-IntroduceSiteProfilesSettings.rst:29

    Is "MyProfile" required to be named that way or can I choose it? I assume the later, as it correlates with the label below?

    Feature-103437-IntroduceSiteProfilesSettings.rst:45

    When I understand correctly, the settings definition is used, when I ship settings in my (3rd-party) extension with sane defaults. The settings can then be used to override a default setting value with a custom value in a project's installation?

    Feature-103437-IntroduceSiteProfilesSettings.rst:56

    What impact does this settings have? I assume, there will be some GUI (later?) where this is displayed?

    Feature-103437-IntroduceSiteProfilesSettings.rst:66

    Currently, the difference here between "default settings" and "default values" is unclear to me.
  61. Benjamin Franzke marked it work in progress 04/02/24, 16:18

  62. Benjamin Franzke commented on patch set 28 04/02/24, 16:25

    ProfileRegistry.php:92

    This'll receive functionals tomorrow

    SettingsInterface.php:20

    all Settings api's will be marked `@internal` for now, as the upcoming patches – e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/83623 – may need to perform changes. Specific tests for edge cases will then be added, once we have consensus on the interface. For now styleguide acts as acceptance testbed: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83526

    SettingsTypeRegistry.php:24

    will be dropped. Using this as a TODO collector for missing types: * `stringlist` (e.g. `['foo', 'bar']`) * some kind of `orderedlist`? (=indexed array) {10: 'EXT:foo/bar…) * `float` (or `number`?)
  63. Benjamin Franzke commented on patch set 28 04/03/24, 07:26

    Feature-103437-IntroduceSiteProfilesSettings.rst:29

    Needs to be fixed to: `Configuration/Profiles/MyProfile`
  64. Benjamin Franzke uploaded patch set 29 V +1 04/03/24, 08:04

  65. Benjamin Franzke commented on patch set 29 04/03/24, 08:04

    Reply

    Thanks for your comments. I tried to rephrase, but it's not final yet. I actually removed the WIP flag by accident – I wasn't finished with this patch at all. …but it turns out it's not too bad to receive early feedback :) To be transparent: We're not even sold on the name "profile" yet, as some say it does not explain/fit-to what it provides.

    ProfileRegistry.php:92 Reply

    Done

    SettingsInterface.php:20 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:18 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:29 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:29 Reply

    A random name, tried to clarify that.

    Feature-103437-IntroduceSiteProfilesSettings.rst:45 Reply

    ack, or to set setting for a profile that your profile depends on.

    Feature-103437-IntroduceSiteProfilesSettings.rst:56 Reply

    Yes, that's what is planned to be done. We want a GUI where settings can be applied to a site (stored in config/sites/*/settings.yaml) based on the profile's that are activated for that site. (Profile settings inside profiles are to be set manually)

    Feature-103437-IntroduceSiteProfilesSettings.rst:66 Reply

    Tried to reword.
  66. core-ci voted on patch set 29 V -1 04/03/24, 08:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55209

  67. Benjamin Franzke uploaded patch set 30 V -1 04/03/24, 08:17

  68. core-ci voted on patch set 30 V +1 04/03/24, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55210

  69. Benjamin Franzke uploaded patch set 31 V +1 04/03/24, 08:49

  70. core-ci voted on patch set 31 V -1 04/03/24, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55211

  71. Benjamin Franzke uploaded patch set 32 V -1 04/03/24, 09:03

  72. core-ci voted on patch set 32 V +1 04/03/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55212

  73. Benjamin Franzke commented on patch set 32 04/03/24, 14:10

    AbstractServiceProvider.php:198

    typo

    ProfileCollector.php:48

    split into a separate factory

    ProfileDefinition.php:31

    drop

    ProfileDefinition.php:32

    add optionalDependencies

    ProfileDefinition.php:33

    drop for now

    ProfileDefinition.php:37

    contentBlocks

    ProfileRegistry.php:142

    typo
  74. Benjamin Franzke uploaded patch set 33 V +1 04/03/24, 20:46

  75. core-ci voted on patch set 33 V -1 04/03/24, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55276

  76. Benjamin Franzke uploaded patch set 34 V -1 04/03/24, 20:53

  77. core-ci voted on patch set 34 V +1 04/03/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55277

  78. Benjamin Franzke commented on patch set 34 04/03/24, 21:28

    AbstractServiceProvider.php:198 Reply

    Done

    ProfileCollector.php:48 Reply

    Done

    ProfileDefinition.php:31 Reply

    Done

    ProfileDefinition.php:32 Reply

    Done

    ProfileDefinition.php:33 Reply

    Done

    ProfileDefinition.php:37 Reply

    Skipped for later.

    ProfileRegistry.php:142 Reply

    Done
  79. Benjamin Kott commented on patch set 34 04/04/24, 06:15

    This change is ready for review.

    SettingDefinition.php:36

    missing: - categories - tags

    Feature-103437-IntroduceSiteSets.rst:30

    should we introduce the casing here again or go all lowercase?
  80. Benjamin Franzke marked it work in progress 04/04/24, 06:17

  81. Benjamin Franzke uploaded patch set 35 V +1 04/04/24, 06:52

  82. Benjamin Franzke commented on patch set 35 04/04/24, 06:52

    SettingDefinition.php:36 Reply

    added, but still need to be evaluated (somewhere).

    Feature-103437-IntroduceSiteSets.rst:30 Reply

    I'm fine with lowercase – I actually don't care (and the code doesn't), but yea, we need to decide on a convention that we use in code and docs..
  83. core-ci voted on patch set 35 V -1 04/04/24, 07:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55312

  84. Benjamin Franzke uploaded patch set 36 V -1 04/04/24, 07:06

  85. core-ci voted on patch set 36 V +1 04/04/24, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55316

  86. Chris Müller commented on patch set 36 04/04/24, 17:18

    Feature-103437-IntroduceSiteSets.rst:30 Reply

    I agree with the convention, and speaking for the documentation: I would like to have one spelling, otherwise we have to explain to the user, why some folder names must be PascalCase, others can be either PascalCase or lowercase/kebap-case - which will be very confusing to our users (and error-prone). So, "Configuration/Sets/MySet/" looks fine for me, also "configuration/sets/my-set/" (also when both are valid and the user can choose) - but using "Configuration/Sets/my-set" or "Configuration/Sets/myset" does no-one really understand (and is confusing). Personally, I don't care which variant we recommend - but I care about **consistency** in the docs. When we go the lowercase/kebap-case way, I am strongly for streamlining all paths in the docs for v13 (with admonitions that both ways are valid, also for backwards compat) - and this will be then the **recommendation** for folder names in extensions. IMHO, this then also has to be adjusted for: "classes/DataHandling/MyDataHandler.php" or "resources/private/language/locallang.xlf".
  87. Oli Bartsch commented on patch set 36 04/04/24, 17:29

    This change is ready for review.

    ItemsProcessorFunctions.php:130

    $label is not nullable AFAICS

    SiteDatabaseEditRow.php:95

    I suggest to ensure that $configuration['dependencies'] is an array.

    site.php:72

    Can be left out I think

    locallang_siteconfiguration_tca.xlf:25

    I suggest to omit the "Select"

    SettingDefinition.php:23

    can be readonly

    SettingDefinition.php:32

    Why nullable?

    SettingDefinition.php:35

    Why nullable?

    Settings.php:23

    can be readonly

    Site.php:76

    protected array $sets;

    SetDefinition.php:22

    can be readonly

    YamlSetDefinitionProvider.php:82

    What about allowing settings.*.yaml? So its possible to add separat files, e.g. "settings.styles.yaml" or "settings.tx_news.yaml", while "settings.definitions.yaml" is a special case, already resolved beforehand.

    Feature-103437-IntroduceSiteSets.rst:33

    Isn't this more an `identifier`?

    Feature-103437-IntroduceSiteSets.rst:64

    Does this represent any hierarchy? Shouldn't this for consistency also be declared as `name` or `identifier`?
  88. Garvin Hicking commented on patch set 36 04/04/24, 17:37

    Feature-103437-IntroduceSiteSets.rst:30 Reply

    Personal oppinion: It was a long way to establish uppercasing. I think reverting a recommendation to go lowecase will be confusing. Allowing every directory to be either lower or uppercased can have a performance impact due to double I/O filestat lookups. I'd vote for keeping UpperCamelCase as the recommendation. IMO this really needs a global decission and not creep into specific features. Then we'll have extensions using mixtures of casing and it'll go a kraut-and-rüben-style. /soapbox
  89. Benjamin Franzke marked it work in progress 04/04/24, 18:50

  90. Benjamin Franzke uploaded patch set 37 V +1 04/05/24, 08:45

  91. Benjamin Franzke commented on patch set 37 04/05/24, 08:45

    ItemsProcessorFunctions.php:130 Reply

    thanks, good catch, was changed in recents patchsets to be not nullable.

    SiteDatabaseEditRow.php:95 Reply

    Done

    site.php:72 Reply

    Done

    locallang_siteconfiguration_tca.xlf:25 Reply

    ack, fits better to the other labels 👍

    SettingDefinition.php:23 Reply

    Done

    SettingDefinition.php:32 Reply

    Removed

    SettingDefinition.php:35 Reply

    Removed

    Settings.php:23 Reply

    Done

    Site.php:76 Reply

    Done

    SetDefinition.php:22 Reply

    Done

    YamlSetDefinitionProvider.php:82 Reply

    Wouldn't do that for now to be honest, no particular reason, just unneeded overhead IMO.

    Feature-103437-IntroduceSiteSets.rst:33 Reply

    `identifier` would be fine as well, but I chose `name` on purpose to match the field used by `composer.json` and `package.json` as well. Hope it's fine for you if I resolve this one immediately.

    Feature-103437-IntroduceSiteSets.rst:64 Reply

    The idea is to use a flat structure here. And we don't want sometime like two identifiers. This represents the hierarchy for the object-storage. UI hierarchy will be represented via `category`. (As our settings are "more" nested that we'd like the UI to be.)
  92. core-ci voted on patch set 37 V +1 04/05/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55373

  93. Benjamin Franzke uploaded patch set 38 V +1 04/05/24, 15:08

  94. core-ci voted on patch set 38 V -1 04/05/24, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55391

  1. Benjamin Franzke uploaded patch set 39 V -1 04/05/24, 20:39

  2. core-ci voted on patch set 39 V +1 04/05/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55395

  3. Benjamin Franzke uploaded patch set 40 V +1 04/06/24, 09:02

  4. core-ci voted on patch set 40 V +1 04/06/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55428

  5. Benjamin Franzke marked it ready for review 04/06/24, 15:01

  6. Benjamin Franzke uploaded patch set 41 V +1 04/06/24, 15:59

  7. core-ci voted on patch set 41 V +1 04/06/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55440

  8. Benjamin Franzke uploaded patch set 42 V +1 04/06/24, 16:27

  9. core-ci voted on patch set 42 V +1 04/06/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55445

  10. Benjamin Kott commented on patch set 42 04/06/24, 19:47

    SettingDefinition.php:36 Reply

    Done

    YamlSetDefinitionProvider.php:82 Reply

    we have a mixture here since we already have settings.defitions.yaml that would also follow that scheme. In addition we would have again an undefined state of loading order. it´s already possible if you define a set for these options.

    Feature-103437-IntroduceSiteSets.rst:64 Reply

    Done
  11. Benni Mack commented on patch set 42 04/06/24, 20:05

    Site.php:328

    $this->sets !== [] is faster.

    YamlSetDefinitionProvider.php:82 Reply

    might be an "idea" which I think we should handle separately (in a further patch) - maybe you want to open a separate ticket for this
  12. Benjamin Kott commented on patch set 42 04/06/24, 21:01

    YamlSetDefinitionProvider.php:82 Reply

    Done
  13. Benjamin Franzke uploaded patch set 43 V +1 04/06/24, 23:40

  14. Benjamin Franzke commented on patch set 43 04/06/24, 23:40

    Reply

    I've splitted the FEATURE into three featurs because the TypoScript part deserves a distinct explanation: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83119 Please note that the details of this API may still change until 13.1 is released, so please wait a bit until you adopt documentation from the Feature.rst (otherwise it may be duplicate work if you need to track future changes to the rst)

    SettingsTypeRegistry.php:24 Reply

    Done

    Site.php:328 Reply

    lol, i actually used that in the next commit as well, but forgot to squash that into the right patch :)

    Feature-103437-IntroduceSiteProfilesSettings.rst:29 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:45 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:56 Reply

    Done

    Feature-103437-IntroduceSiteProfilesSettings.rst:66 Reply

    Done

    Feature-103437-IntroduceSiteSets.rst:30 Reply

    We'll go with this convention for now, but will keep to allow both, as we might introduce all-lowercase at *SOME* point (no concrete plans at all).
  15. core-ci voted on patch set 43 V +1 04/06/24, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55455

  16. Benni Mack voted on patch set 43 CR +1 V +1 04/07/24, 07:03

  17. Benjamin Kott commented on patch set 43 CR -1 04/07/24, 08:31

    I would prefer if we find a different wording for the new bundles, what about profiles?
  18. Garvin Hicking commented on patch set 43 04/07/24, 08:58

    Reply

    "Site-sets settings set" can be a bit of a tongue breaker. ;) I do like profiles, even bundles, maybe collection (kind of associating with FAL/record Collections?)...
  19. Benjamin Kott voted on patch set 43 CR +1 V +1 04/07/24, 09:11

  20. Benjamin Kott commented on patch set 43 04/07/24, 09:12

    Reply

    Done, was only a joke for the surfcamp
  21. Oli Bartsch voted on patch set 43 CR +1 V +1 04/07/24, 09:15

  22. Oli Bartsch commented on patch set 43 04/07/24, 09:16

    Great Feature.
    Great work!
  23. Benjamin Franzke voted on patch set 43 CR +2 V +2 04/07/24, 09:17

  24. Benjamin Franzke merged patch set 44 04/07/24, 09:17

  25. Christian Kuhn commented on patch set 43 04/07/24, 09:23

    AbstractServiceProvider.php:191 Unresolved

    this is cached per package, and is compile-time, right? i'm asking since symfony finder can be quite slow, especially when called often. finder performance was the reason to implement 'native' file finding for @import in new TS parser ... is it worth doing this stuff here 'manually' as well?

    SettingDefinition.php:23 Unresolved

    final possibly? similar question for various other classes below.