Review main Merged

82192[TASK] Notify user about forced module redirect

Oli Bartsch CR +2 V +2 Normal +168 −25 updated 12/20/23, 11:53

Commit message

There might be valid reasons for a module
being (temporary) inaccessible for a user.
Since #102665 a module redirect is done
instead of throwing an exception, which
a user can not resolve.

However, this led to the fact that a user
got redirected without knowing the reason.
Therefore, a notification is now dispatched,
whenever a forced module redirect takes place.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Achim Fritz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Achim Fritz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1013

  1. Oli Bartsch uploaded patch set 1 12/15/23, 20:46

  2. Oli Bartsch uploaded patch set 2 12/15/23, 20:51

  3. core-ci voted on patch set 1 V +1 12/15/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50726

  4. core-ci voted on patch set 2 V +1 12/15/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50727

  5. Benni Mack commented on patch set 2 12/15/23, 22:31

    Does not work for me: I set my startup module to "dashboard", uninstalled dashboard, also used a deeplink to dashboard, and re-logged in - no message appears.
  6. Oli Bartsch commented on patch set 2 12/18/23, 09:28

    Reply

    That's intended as the invalid module can not be resolved => because it is no longer registered after uninstalling the extension. The patch is about (temporary) missing access permissions for existing modules. For your use case, we could only tell the user that the currently defined start module value is invalid, but this is IMO another topic, because this behaviour did not change with #102665.
  7. Oli Bartsch uploaded patch set 3 V +1 12/19/23, 10:12

  8. core-ci voted on patch set 3 V +1 12/19/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50802

  9. Benjamin Franzke commented on patch set 3 CR +1 V +1 12/19/23, 10:34

    As discussed on slack, I'd increase the notification timeout for INFO/NOTICE to at least 10 seconds (instead of 5), in order for such notifications to be readable without time pressure. But that's up for a different change.
  10. Achim Fritz voted on patch set 3 CR +1 V +1 12/20/23, 10:59

  11. Benni Mack voted on patch set 3 CR +1 V +1 12/20/23, 11:03

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 12/20/23, 11:53

  13. Oli Bartsch merged patch set 4 12/20/23, 11:53