82196[FEATURE] Enable webp support in ImageMagick/GraphicsMagick
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php3+57 −5
- typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php+5 −2
- typo3/sysext/core/Classes/Resource/Processing/ImagePreviewTask.php+4 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-88537-WebPImageFormatSupportForImageProcessing.rstnew+58 −0
- typo3/sysext/reports/Classes/Report/Status/ImageProcessingStatus.phpnew+91 −0
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf+21 −0
Review log 911
-
Benni Mack uploaded patch set 1 12/16/23, 21:40
-
core-ci voted on patch set 1 V +1 12/16/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50741
-
Benni Mack uploaded patch set 2
V +112/16/23, 22:11 -
core-ci voted on patch set 2 V +1 12/16/23, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50742
-
Simon Schaufelberger commented on patch set 2 CR +1 V +1 12/16/23, 23:27
tested GifBuilder and worked! -
Guido Schmechel commented on patch set 2 12/18/23, 05:43
GraphicalFunctions.php:202A quick question: The "101" occurs 3 times. Do we have to make a variable out of it? There is currently a bit of inconsistency in the class about how to deal with such values. -
Benni Mack commented on patch set 2 12/18/23, 07:38
GraphicalFunctions.php:202Reply101 is taken from GifBuilder where this matches to https://www.php.net/manual/en/image.constants.php#:~:text=of%20PHP%207.0.10)-,IMG_WEBP_LOSSLESS,-(int) which I do not want to use as it is not related to WEBP. We could use a constant, but I'd rather like to centralize this option in the future around all our GFX settings so we could then use a constant, if that's alright? -
Guido Schmechel commented on patch set 2 12/18/23, 08:07
GraphicalFunctions.php:202ReplyAlright, this is fine for me. -
Christian Kuhn voted on patch set 2 CR +1 V +1 12/18/23, 10:11
-
Benni Mack commented on patch set 2 CR +2 V +2 12/18/23, 10:12
Thank you! Finally. -
Benni Mack merged patch set 3 12/18/23, 10:12