82197[TASK] Add Test Image for reading webp images
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1316
-
Benni Mack uploaded patch set 1 12/16/23, 22:24
-
core-ci voted on patch set 1 V +1 12/16/23, 22:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50743
-
Simon Schaufelberger commented on patch set 1 V -1 12/16/23, 23:15
webp is not added in imagefile_ext yet, -
Simon Schaufelberger commented on patch set 1 12/16/23, 23:15
EnvironmentController.php:386empty line before missing to be consistent. -
Benni Mack commented on patch set 1 CR -2 12/16/23, 23:18
Yes. Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/82196 first. No need to review this one for the time being then -
Simon Schaufelberger commented on patch set 1 12/16/23, 23:21
Reply
DefaultConfiguration.php looks like this: 'imagefile_ext' => 'gif,jpg,jpeg,tif,tiff,bmp,pcx,tga,png,pdf,ai,svg', -
Simon Schaufelberger commented on patch set 1 12/16/23, 23:30
Reply
ok, wouldn't it make sense to combine both patches? -
Benni Mack voted on patch set 1 CR 0 12/18/23, 10:21
-
Benni Mack rebased onto patch set 2
V +112/18/23, 10:21 -
Benni Mack commented on patch set 3 12/18/23, 10:22
Published edit on patch set 2. -
Benni Mack commented on patch set 3 12/18/23, 10:22
Reply
doneReply
doneEnvironmentController.php:386ReplyDone -
core-ci voted on patch set 2 V +1 12/18/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50763
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 12/18/23, 10:28
-
core-ci voted on patch set 3 V +1 12/18/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50764
-
Oli Bartsch voted on patch set 3 CR +2 V +2 12/18/23, 10:41
-
Oli Bartsch merged patch set 4 12/18/23, 10:41