Review main Merged

82198[BUGFIX] Fix backend layout lookup in page info module

Torben Hansen CR +2 V +2 Easy +6 −2 updated 12/18/23, 10:00

Commit message

The page info module currently shows a valid page layout as invalid,
because the lookup of backend layouts still uses indexed array keys
instead of associative array keys which were introduced in #99739

This change fixes the problem by using associative array keys
to resolve backend layouts. Additionally, this change ensures,
that the `determinePageId` function in `BackendLayoutView`
does not try to resolve a page id, if the given array is empty.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Torben Hansen uploaded patch set 1 12/17/23, 18:47

  2. Torben Hansen uploaded patch set 2 12/17/23, 18:49

  3. core-ci voted on patch set 1 V +1 12/17/23, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50750

  4. core-ci voted on patch set 2 V +1 12/17/23, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50751

  5. Benni Mack voted on patch set 2 CR +1 V +1 12/17/23, 20:59

  6. Guido Schmechel voted on patch set 2 CR +1 12/18/23, 05:45

  7. Nikita Hovratov updated the commit message in patch set 3 CR +1 V +1 12/18/23, 09:18

  8. Nikita Hovratov voted on patch set 3 CR +1 V +1 12/18/23, 09:18

  9. core-ci voted on patch set 3 V +1 12/18/23, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50759

  10. Nikita Hovratov commented on patch set 3 12/18/23, 09:24

    PageInformationController.php:541

    While we are at it: I don't understand, what these two checks are for. Having a "falsy" label leads to "Invalid value" as well. Can be tackled in a separate patch though.
  11. Benni Mack voted on patch set 3 CR +1 V +1 12/18/23, 09:43

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 12/18/23, 09:43

  13. Oli Bartsch merged patch set 4 12/18/23, 10:00