Review main Merged

82263[BUGFIX] Proper styleguide data generator MM fields

Christian Kuhn CR +2 V +2 Normal +46 −89 updated 12/20/23, 13:15

Commit message

Patch for #102279 to auto-create DB select fields
reveals a bug in the styleguide data generator which
tries to create (partially empty) strings for the
"parent count" fields when select is configured with
MM.
The patch adapts the generator logic a bit to create
better values in those cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 69

  1. Christian Kuhn uploaded patch set 1 12/20/23, 12:03

  2. core-ci voted on patch set 1 V +1 12/20/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50845

  3. core-ci commented on patch set 1 12/20/23, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50846

  4. Christian Kuhn uploaded patch set 2 V +1 12/20/23, 12:31

  5. core-ci voted on patch set 2 V +1 12/20/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50847

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/20/23, 12:40

  7. Stefan Bürk voted on patch set 2 CR +1 V +1 12/20/23, 13:13

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 12/20/23, 13:15

  9. Christian Kuhn merged patch set 3 12/20/23, 13:15