Review main Merged

82266[TASK] Replace Bootstrap::initializeLanguageObject() in tests

Benni Mack CR +2 V +2 Hard +227 −245 updated 12/22/23, 11:34

Commit message

This change uses the LanguageServiceFactory
directly (mostly in tests) instead of
Bootstrap::initializeLanguageObject() in order
to explicitly define $GLOBALS['LANG'], thus showing
the dependency to the global object.

The internal method Bootstrap::initializeLanguageObject()
can thus be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 76

Show 56 more files

Review log 1117

  1. Benni Mack uploaded patch set 1 12/21/23, 08:52

  2. core-ci voted on patch set 1 V -1 12/21/23, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50860

  3. Benni Mack uploaded patch set 2 V -1 12/21/23, 09:03

  4. Benni Mack uploaded patch set 3 12/21/23, 09:05

  5. core-ci voted on patch set 2 V -1 12/21/23, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50861

  6. core-ci voted on patch set 3 V -1 12/21/23, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50862

  7. Benni Mack uploaded patch set 4 V -1 12/21/23, 09:24

  8. core-ci voted on patch set 4 V -1 12/21/23, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50863

  9. Benni Mack uploaded patch set 5 V -1 12/21/23, 09:37

  10. core-ci voted on patch set 5 V +1 12/21/23, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50864

  11. Benni Mack updated the commit message in patch set 6 V +1 12/21/23, 19:26

  12. core-ci voted on patch set 6 V +1 12/21/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50875

  13. Nikita Hovratov voted on patch set 6 CR +1 V +1 12/21/23, 19:55

  14. Oliver Klee voted on patch set 6 V +1 12/21/23, 20:06

  15. Stefan Bürk voted on patch set 6 CR +1 V +1 12/21/23, 22:37

  16. Benni Mack voted on patch set 6 CR +2 V +2 12/22/23, 11:34

  17. Benni Mack merged patch set 7 12/22/23, 11:34