82276[TASK] Avoid usages to TSFE->sys_page
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Sascha Nowak +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 21
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+13 −5
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslationTest.php+0 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ActionViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ActionViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+0 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+0 −3
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php+1 −9
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+21 −16
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+4 −7
- typo3/sysext/frontend/Classes/Page/PageInformation.php+0 −19
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+0 −2
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+5 −3
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php2+8 −5
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/FilesContentObjectTest.php+0 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+9 −5
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+2 −1
Show 1 more file
Review log 1419
-
Benni Mack uploaded patch set 1 12/23/23, 13:05
-
core-ci voted on patch set 1 V -1 12/23/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50931
-
Benni Mack uploaded patch set 2
V -112/27/23, 21:10 -
core-ci voted on patch set 2 V +1 12/27/23, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50966
-
Benni Mack uploaded patch set 3
V +112/27/23, 21:33 -
core-ci voted on patch set 3 V -1 12/27/23, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50967
-
Benni Mack uploaded patch set 4
V -112/27/23, 21:41 -
core-ci voted on patch set 4 V +1 12/27/23, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50968
-
Simon Schaufelberger voted on patch set 4 CR +1 12/28/23, 13:12
-
Oliver Klee voted on patch set 4 V +1 12/28/23, 15:35
-
Sascha Nowak commented on patch set 4 12/29/23, 07:14
PageLinkBuilder.php:306Why are you not using the $this->buildPageRepository() here? -
Christian Kuhn commented on patch set 4 12/30/23, 14:25
I think we could remove the instance from PageInformation along the way.ContentObjectRenderer.php:5378ReplyDonePageLinkBuilder.php:306Replyto not manipulate the context language attribute here. -
Christian Kuhn uploaded patch set 5
CR +1V +112/30/23, 14:27 -
core-ci voted on patch set 5 V +1 12/30/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51021
-
Christian Kuhn voted on patch set 5 CR +1 V +1 12/30/23, 14:40
-
Sascha Nowak voted on patch set 5 CR +1 12/30/23, 14:51
-
Oliver Klee voted on patch set 5 V +1 12/30/23, 14:57
-
Christian Kuhn voted on patch set 5 CR +2 V +2 12/30/23, 15:07
-
Christian Kuhn merged patch set 6 12/30/23, 15:07
ContentObjectRenderer.php:5378