Review main Merged

82276[TASK] Avoid usages to TSFE->sys_page

Benni Mack CR +2 V +2 Normal +66 −108 updated 12/30/23, 15:07

Commit message

Since TYPO3 v9, PageRepository dependencies
are in better shape with the introduction
of Context API.

With TYPO3 v12, it is fully encapsulated
and can now be called and instantiated
when needed, instead of using TSFE->sys_page.

This patch migrates the last occurrences
in TYPO3 Core and only sets TSFE->sys_page
as b/w compat layer (deprecation later together
with other properties).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Sascha Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1419

  1. Benni Mack uploaded patch set 1 12/23/23, 13:05

  2. core-ci voted on patch set 1 V -1 12/23/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50931

  3. Benni Mack uploaded patch set 2 V -1 12/27/23, 21:10

  4. core-ci voted on patch set 2 V +1 12/27/23, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50966

  5. Benni Mack uploaded patch set 3 V +1 12/27/23, 21:33

  6. core-ci voted on patch set 3 V -1 12/27/23, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50967

  7. Benni Mack uploaded patch set 4 V -1 12/27/23, 21:41

  8. core-ci voted on patch set 4 V +1 12/27/23, 21:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50968

  9. Simon Schaufelberger voted on patch set 4 CR +1 12/28/23, 13:12

  10. Oliver Klee voted on patch set 4 V +1 12/28/23, 15:35

  11. Sascha Nowak commented on patch set 4 12/29/23, 07:14

    ContentObjectRenderer.php:5378

    $pageRepository = $this->getPageRepository();

    PageLinkBuilder.php:306

    Why are you not using the $this->buildPageRepository() here?
  12. Christian Kuhn commented on patch set 4 12/30/23, 14:25

    I think we could remove the instance from PageInformation along the way.

    ContentObjectRenderer.php:5378 Reply

    Done

    PageLinkBuilder.php:306 Reply

    to not manipulate the context language attribute here.
  13. Christian Kuhn uploaded patch set 5 CR +1 V +1 12/30/23, 14:27

  14. core-ci voted on patch set 5 V +1 12/30/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51021

  15. Christian Kuhn voted on patch set 5 CR +1 V +1 12/30/23, 14:40

  16. Sascha Nowak voted on patch set 5 CR +1 12/30/23, 14:51

  17. Oliver Klee voted on patch set 5 V +1 12/30/23, 14:57

  18. Christian Kuhn voted on patch set 5 CR +2 V +2 12/30/23, 15:07

  19. Christian Kuhn merged patch set 6 12/30/23, 15:07