Review main Merged

82277[TASK] Avoid TSFE->MP

Christian Kuhn CR +2 V +2 Hard +102 −154 updated 01/09/24, 12:20

Commit message

Based on the new PageInformation object attached to the
Request from #102715, we can get rid of usages of
TSFE->MP property.

The patch does this and streamlines an admin panel class
and the seo CanonicalGenerator class along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Benni Mack +1

Issues 2

Files 17

Review log 1723

  1. Christian Kuhn uploaded patch set 1 12/23/23, 13:51

  2. core-ci voted on patch set 1 V -1 12/23/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50932

  3. Christian Kuhn uploaded patch set 2 V -1 01/09/24, 09:57

  4. core-ci voted on patch set 2 V -1 01/09/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51316

  5. Christian Kuhn uploaded patch set 3 V -1 01/09/24, 10:39

  6. core-ci voted on patch set 3 V +1 01/09/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51321

  7. Christian Kuhn updated the commit message in patch set 4 V +1 01/09/24, 10:48

  8. core-ci voted on patch set 4 V +1 01/09/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51323

  9. Benni Mack commented on patch set 4 01/09/24, 10:54

    PageLinkBuilder.php:584

    why do you remove this?
  10. Christian Kuhn commented on patch set 4 01/09/24, 10:57

    PageLinkBuilder.php:584 Reply

    it's merged into the if above.
  11. Christian Kuhn commented on patch set 4 CR -1 01/09/24, 10:58

    PageLinkBuilder.php:584 Reply

    actually ... mom.
  12. Christian Kuhn uploaded patch set 5 CR -1 V +1 01/09/24, 11:03

  13. core-ci voted on patch set 5 V +1 01/09/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51324

  14. Christian Kuhn commented on patch set 5 01/09/24, 11:10

    PageLinkBuilder.php:584 Reply

    good catch. thx.
  15. Stefan Bürk voted on patch set 5 CR +1 V +1 01/09/24, 11:42

  16. Oli Bartsch commented on patch set 5 01/09/24, 12:08

    GeneralInformation.php:30

    unused import

    CanonicalGenerator.php:36

    can be readonly

    ModifyUrlForCanonicalTagEventTest.php:38

    let's keep a actual getter check here
  17. Oli Bartsch uploaded patch set 6 CR +1 V +1 01/09/24, 12:09

  18. Oli Bartsch commented on patch set 6 CR +1 V +1 01/09/24, 12:09

    GeneralInformation.php:30 Reply

    Done

    CanonicalGenerator.php:36 Reply

    Done

    ModifyUrlForCanonicalTagEventTest.php:38 Reply

    Done
  19. Benni Mack voted on patch set 6 CR +1 V +1 01/09/24, 12:12

  20. Stefan Bürk voted on patch set 6 CR +1 V +1 01/09/24, 12:16

  21. Christian Kuhn voted on patch set 6 CR +2 V +2 01/09/24, 12:19

  22. Christian Kuhn merged patch set 7 01/09/24, 12:19

  23. core-ci voted on patch set 6 V +1 01/09/24, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51326