82277[TASK] Avoid TSFE->MP
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- Benni Mack +1
Issues 2
Files 17
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php2+11 −19
- typo3/sysext/adminpanel/Configuration/Services.yaml+2 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+19 −19
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+0 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php4+8 −6
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/PageExposingTsfeMpParameter.typoscriptdeleted+0 −3
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/PageHelloWorld.typoscriptnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/TypoScriptFrontendControllerTestUserFuncs.php+0 −11
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+1 −45
- typo3/sysext/indexed_search/Classes/EventListener/FrontendGenerationPageIndexingTrigger.php+10 −6
- typo3/sysext/redirects/Classes/Service/RedirectService.php+1 −3
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php2+36 −32
- typo3/sysext/seo/Classes/Event/ModifyUrlForCanonicalTagEvent.php+2 −1
- typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php+1 −1
- typo3/sysext/seo/Configuration/Services.yaml+3 −0
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+1 −1
- typo3/sysext/seo/Tests/Unit/Event/ModifyUrlForCanonicalTagEventTest.php2+4 −5
Review log 1723
-
Christian Kuhn uploaded patch set 1 12/23/23, 13:51
-
core-ci voted on patch set 1 V -1 12/23/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50932
-
Christian Kuhn uploaded patch set 2
V -101/09/24, 09:57 -
core-ci voted on patch set 2 V -1 01/09/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51316
-
Christian Kuhn uploaded patch set 3
V -101/09/24, 10:39 -
core-ci voted on patch set 3 V +1 01/09/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51321
-
Christian Kuhn updated the commit message in patch set 4
V +101/09/24, 10:48 -
core-ci voted on patch set 4 V +1 01/09/24, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51323
-
Benni Mack commented on patch set 4 01/09/24, 10:54
-
Christian Kuhn commented on patch set 4 01/09/24, 10:57
PageLinkBuilder.php:584Replyit's merged into the if above. -
Christian Kuhn commented on patch set 4 CR -1 01/09/24, 10:58
PageLinkBuilder.php:584Replyactually ... mom. -
Christian Kuhn uploaded patch set 5
CR -1V +101/09/24, 11:03 -
core-ci voted on patch set 5 V +1 01/09/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51324
-
Christian Kuhn commented on patch set 5 01/09/24, 11:10
PageLinkBuilder.php:584Replygood catch. thx. -
Stefan Bürk voted on patch set 5 CR +1 V +1 01/09/24, 11:42
-
Oli Bartsch commented on patch set 5 01/09/24, 12:08
GeneralInformation.php:30unused importCanonicalGenerator.php:36can be readonlyModifyUrlForCanonicalTagEventTest.php:38let's keep a actual getter check here -
Oli Bartsch uploaded patch set 6
CR +1V +101/09/24, 12:09 -
Oli Bartsch commented on patch set 6 CR +1 V +1 01/09/24, 12:09
GeneralInformation.php:30ReplyDoneCanonicalGenerator.php:36ReplyDoneModifyUrlForCanonicalTagEventTest.php:38ReplyDone -
Benni Mack voted on patch set 6 CR +1 V +1 01/09/24, 12:12
-
Stefan Bürk voted on patch set 6 CR +1 V +1 01/09/24, 12:16
-
Christian Kuhn voted on patch set 6 CR +2 V +2 01/09/24, 12:19
-
Christian Kuhn merged patch set 7 01/09/24, 12:19
-
core-ci voted on patch set 6 V +1 01/09/24, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51326
PageLinkBuilder.php:584