Review main Merged Breaking

82289[!!!][TASK] Remove TS showForgotPasswordLink in ext:felogin

Torben Hansen CR +2 V +2 Easy +39 −4 updated 12/30/23, 14:58

Commit message

The `showForgotPasswordLink` setting in ext:felogin has never been
used in default Fluid templates and has only been kept for backward
compatibility reasons.

It has however been forgotten to remove the deprecated setting in
TYPO3 v12 default TypoScript. This change finally removes the
deprecated and unused TypoScript setting.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1013

  1. Torben Hansen uploaded patch set 1 12/30/23, 14:00

  2. core-ci voted on patch set 1 V +1 12/30/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51018

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 12/30/23, 14:20

  4. Simon Schaufelberger commented on patch set 1 12/30/23, 14:25

    Breaking-102731-RemoveTypoScriptSettingShowForgotPasswordLinkInExtfelogin.rst:39

    please add Typoscript as well. this helps me for tagging in rector
  5. Christian Kuhn uploaded patch set 2 CR +1 V +1 12/30/23, 14:45

  6. Christian Kuhn commented on patch set 1 12/30/23, 14:46

    Breaking-102731-RemoveTypoScriptSettingShowForgotPasswordLinkInExtfelogin.rst:39 Reply

    Done
  7. Christian Kuhn uploaded patch set 3 12/30/23, 14:47

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 12/30/23, 14:47

  9. core-ci voted on patch set 2 V +1 12/30/23, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51022

  10. core-ci voted on patch set 3 V +1 12/30/23, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51023

  11. Jasmina Ließmann voted on patch set 3 CR +1 V +1 12/30/23, 14:57

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 12/30/23, 14:58

  13. Christian Kuhn merged patch set 4 12/30/23, 14:58