Review main Merged

82295[BUGFIX] Respect empty alt attribute in ImageViewhelper

Oli Bartsch CR +2 V +2 Easy +47 −2 updated 01/03/24, 06:04

Commit message

The ImageViewhelper does by default add the
`alternative` property as `alt` attribute to
the img tag if no non-empty string is set.

However, there might be valid use cases where
an empty `alt` attribute should be set for such
image - even if the property exists. Such case
is e.g. a thumbnail of such image.

The ImageViewhelper does therefore now render
an empty `alt` attribute if the `alt` argument
is explicitly set to an empty string.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 01/02/24, 10:31

  2. core-ci voted on patch set 1 V +1 01/02/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51045

  3. Oli Bartsch uploaded patch set 2 V +1 01/02/24, 11:49

  4. core-ci voted on patch set 2 V +1 01/02/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51046

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 01/03/24, 00:49

  6. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/03/24, 06:04

  7. Anja Leichsenring merged patch set 3 01/03/24, 06:04