Review main Merged

82310[TASK] Remove TODO to mark PageRenderer final

Simon Schaufelberger CR +2 V +2 Easy +0 −2 updated 01/05/24, 12:04

Commit message

It was decided that PageRenderer won't become final.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Chris Müller +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Chris Müller +1
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Simon Schaufelberger uploaded patch set 1 01/04/24, 14:51

  2. Simon Schaufelberger commented on patch set 1 01/04/24, 14:53

    Breaking-102752-MarkPageRendererFinal.rst:32

    Please help me here. I have no idea what people should do instead.
  3. core-ci voted on patch set 1 V -1 01/04/24, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51108

  4. Chris Müller commented on patch set 1 01/04/24, 14:57

    Marking PageRenderer as final will make mocking that class in unit tests mostly impossible (without hassle). Mocking is useful, for example, when using PageRenderer hooks, where the PageRenderer itself is given as argument to a hook. There is some patchset available somewhere where we had this discussion already.
  5. Simon Schaufelberger commented on patch set 1 01/04/24, 15:03

    Reply

    ok but Oliver Hader added this TODO here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78658 What do you suggest?
  6. Stefan Bürk commented on patch set 1 CR -1 01/04/24, 15:39

    We discussed it somewhere already to leave this class non-final for now as a lot of people needs to mock this in tests. Simple making it final is not a solution or now. So leave it for now or change the todo to 13.0 or 14.0. Making a interface out of it and than a implementation is not quick step anyway.
  7. Simon Schaufelberger commented on patch set 1 01/04/24, 17:28

    Reply

    ok then I would just remove the TODO.
  8. Simon Schaufelberger uploaded patch set 2 CR -1 V -1 01/04/24, 17:30

  9. core-ci voted on patch set 2 V +1 01/04/24, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51114

  10. Oliver Klee voted on patch set 2 CR +1 V +1 01/04/24, 18:38

  11. Chris Müller voted on patch set 2 CR +1 V +1 01/04/24, 18:57

  12. Torben Hansen voted on patch set 2 CR +1 V +1 01/05/24, 10:22

  13. Simon Schaufelberger commented on patch set 2 01/05/24, 12:02

    Reply

    Done

    Reply

    Done

    Breaking-102752-MarkPageRendererFinal.rst:32 Reply

    Done
  14. Benni Mack voted on patch set 2 CR +2 V +2 01/05/24, 12:03

  15. Benni Mack merged patch set 3 01/05/24, 12:04