Review main Merged Breaking

82332[!!!][FEATURE] Add PSR-14 Event and DTO for modifying resolved ImageResource

Oli Bartsch CR +2 V +2 Hard +589 −177 updated 01/09/24, 10:07

Commit message

This replaces the previously available hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['getImgResource']
which is therefore now removed.

The hook required implementations to implement
the `ContentObjectGetImageResourceHookInterface`,
which is now deprecated as it's unused due to
the hook removal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 2028

Show 23 earlier messages
  1. Oli Bartsch uploaded patch set 1 01/04/24, 15:44

  2. core-ci voted on patch set 1 V -1 01/04/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51110

  3. Oli Bartsch uploaded patch set 2 V -1 01/04/24, 16:00

  1. core-ci voted on patch set 2 V +1 01/04/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51111

  2. Simon Schaufelberger commented on patch set 2 01/04/24, 17:26

    Nice! But I thought all hooks should eventually get transferred into Events?
  3. Oli Bartsch commented on patch set 2 CR -1 01/04/24, 18:36

    Reply

    On it
  4. Simon Schaufelberger commented on patch set 2 01/04/24, 21:36

    Reply

    I mean registration is something different than execution of hooks. This is only the registration which is ok. Needs to be discussed with Benni imho
  5. Oli Bartsch uploaded patch set 3 CR -1 V +1 01/05/24, 17:16

  6. core-ci voted on patch set 3 V -1 01/05/24, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51142

  7. Simon Schaufelberger commented on patch set 3 CR +1 01/05/24, 17:27

    This code looks amazing! Well done!
  8. Simon Schaufelberger voted on patch set 3 CR 0 01/05/24, 19:12

  9. Oli Bartsch uploaded patch set 4 V -1 01/08/24, 11:01

  10. core-ci voted on patch set 4 V +1 01/08/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51217

  11. Oli Bartsch uploaded patch set 5 V +1 01/08/24, 12:33

  12. core-ci voted on patch set 5 V +1 01/08/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51230

  13. Benni Mack uploaded patch set 6 V +1 01/08/24, 13:19

  14. Benni Mack commented on patch set 6 CR +1 V +1 01/08/24, 13:20

    Reply

    done!
  15. core-ci voted on patch set 6 V +1 01/08/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51235

  16. Garvin Hicking commented on patch set 6 01/08/24, 21:46

    Hard work - I can only contribute some grammar notes atm.
    Maybe enhance to "Add PSR-14 event and DTO for..."? To indicate that not only an event is added but also this nifty DTO? Because this DTO sounds like it could play a larger role now.

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:18

    "Event" (other usages also use uppercase "E")

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:20

    "from"

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:53

    "appropriately"? Or just remove the word alltogether for clarity?

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:18

    Uppercase? It's missing the "PSR-14 Event" notation, but other cases where PSR-14 is missing also use "Event" despite of it. Another occurence a few words later, too.

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:35

    Missing ":php:"?

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:36

    Missing ":php:"?

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:71

    "from"
  17. Oli Bartsch uploaded patch set 7 CR +1 V +1 01/09/24, 08:45

  18. core-ci voted on patch set 7 V +1 01/09/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51303

  19. Oli Bartsch uploaded patch set 8 V +1 01/09/24, 08:52

  20. Oli Bartsch commented on patch set 8 01/09/24, 08:52

    Reply

    Done

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:18 Reply

    Done

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:20 Reply

    Done

    Breaking-102755-ImprovedGetImageResourceFunctionality.rst:53 Reply

    Done

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:18 Reply

    Done

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:35 Reply

    Done

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:36 Reply

    Done

    Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:71 Reply

    Done
  21. core-ci voted on patch set 8 V +1 01/09/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51307

  22. Benni Mack voted on patch set 8 CR +1 V +1 01/09/24, 09:19

  23. Christian Kuhn voted on patch set 8 CR +1 V +1 01/09/24, 09:55

  24. Oli Bartsch voted on patch set 8 CR +2 V +2 01/09/24, 10:07

  25. Oli Bartsch merged patch set 9 01/09/24, 10:07