82332[!!!][FEATURE] Add PSR-14 Event and DTO for modifying resolved ImageResource
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 18
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Imaging/ImageResource.phpnew+168 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102755-ImprovedGetImageResourceFunctionality.rst6new+55 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102755-UnusedInterfaceForGetImageResourceHook.rstnew+42 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst8new+73 −0
- typo3/sysext/extbase/Classes/Service/ImageService.php+5 −23
- typo3/sysext/frontend/Classes/ContentObject/Event/AfterImageResourceResolvedEvent.phpnew+55 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectGetImageResourceHookInterface.php+3 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+15 −70
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+15 −24
- typo3/sysext/frontend/Classes/ContentObject/ImageResourceContentObject.php+5 −6
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+36 −37
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+34 −2
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterImageResourceResolvedEventTest.phpnew+59 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+4 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+7 −0
Review log 2028
Show 23 earlier messages
-
Oli Bartsch uploaded patch set 1 01/04/24, 15:44
-
core-ci voted on patch set 1 V -1 01/04/24, 15:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51110
-
Oli Bartsch uploaded patch set 2
V -101/04/24, 16:00
-
core-ci voted on patch set 2 V +1 01/04/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51111
-
Simon Schaufelberger commented on patch set 2 01/04/24, 17:26
Nice! But I thought all hooks should eventually get transferred into Events? -
Oli Bartsch commented on patch set 2 CR -1 01/04/24, 18:36
Reply
On it -
Simon Schaufelberger commented on patch set 2 01/04/24, 21:36
Reply
I mean registration is something different than execution of hooks. This is only the registration which is ok. Needs to be discussed with Benni imho -
Oli Bartsch uploaded patch set 3
CR -1V +101/05/24, 17:16 -
core-ci voted on patch set 3 V -1 01/05/24, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51142
-
Simon Schaufelberger commented on patch set 3 CR +1 01/05/24, 17:27
This code looks amazing! Well done! -
Simon Schaufelberger voted on patch set 3 CR 0 01/05/24, 19:12
-
Oli Bartsch uploaded patch set 4
V -101/08/24, 11:01 -
core-ci voted on patch set 4 V +1 01/08/24, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51217
-
Oli Bartsch uploaded patch set 5
V +101/08/24, 12:33 -
core-ci voted on patch set 5 V +1 01/08/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51230
-
Benni Mack uploaded patch set 6
V +101/08/24, 13:19 -
Benni Mack commented on patch set 6 CR +1 V +1 01/08/24, 13:20
Reply
done! -
core-ci voted on patch set 6 V +1 01/08/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51235
-
Garvin Hicking commented on patch set 6 01/08/24, 21:46
Hard work - I can only contribute some grammar notes atm.Maybe enhance to "Add PSR-14 event and DTO for..."? To indicate that not only an event is added but also this nifty DTO? Because this DTO sounds like it could play a larger role now.Breaking-102755-ImprovedGetImageResourceFunctionality.rst:18"Event" (other usages also use uppercase "E")Breaking-102755-ImprovedGetImageResourceFunctionality.rst:20"from"Breaking-102755-ImprovedGetImageResourceFunctionality.rst:53"appropriately"? Or just remove the word alltogether for clarity?Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:18Uppercase? It's missing the "PSR-14 Event" notation, but other cases where PSR-14 is missing also use "Event" despite of it. Another occurence a few words later, too.Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:35Missing ":php:"?Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:36Missing ":php:"?Feature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:71"from" -
Oli Bartsch uploaded patch set 7
CR +1V +101/09/24, 08:45 -
core-ci voted on patch set 7 V +1 01/09/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51303
-
Oli Bartsch uploaded patch set 8
V +101/09/24, 08:52 -
Oli Bartsch commented on patch set 8 01/09/24, 08:52
Reply
DoneBreaking-102755-ImprovedGetImageResourceFunctionality.rst:18ReplyDoneBreaking-102755-ImprovedGetImageResourceFunctionality.rst:20ReplyDoneBreaking-102755-ImprovedGetImageResourceFunctionality.rst:53ReplyDoneFeature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:18ReplyDoneFeature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:35ReplyDoneFeature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:36ReplyDoneFeature-102755-PSR-14EventForModifyingGetImageResourceResult.rst:71ReplyDone -
core-ci voted on patch set 8 V +1 01/09/24, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51307
-
Benni Mack voted on patch set 8 CR +1 V +1 01/09/24, 09:19
-
Christian Kuhn voted on patch set 8 CR +1 V +1 01/09/24, 09:55
-
Oli Bartsch voted on patch set 8 CR +2 V +2 01/09/24, 10:07
-
Oli Bartsch merged patch set 9 01/09/24, 10:07