Review main Merged

82361[BUGFIX] Check all method for existence in `OpcodeCacheService`

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 01/09/24, 09:14

Commit message

The `\TYPO3\CMS\Core\Service\OpcodeCacheService->isClearable()`
method checks for existence of opcache function and if they are
listed in the `disable_functions` configuration.

It seems, that in some environments both methods are missing
and not listed in the disabled methods. Even if this sounds
odd when the opcache extension is installed but both methods are
not available, we add it to the check to avoid the missleading
error message:

	Call to undefined function
	TYPO3\CMS\Core\Service\opcache_reset()

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Stefan Bürk uploaded patch set 1 01/06/24, 22:58

  2. core-ci voted on patch set 1 V +1 01/06/24, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51177

  3. Oliver Klee voted on patch set 1 CR +1 01/07/24, 09:01

  4. Benni Mack updated the commit message in patch set 2 CR +1 V +1 01/07/24, 20:40

  5. core-ci voted on patch set 2 V +1 01/07/24, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51189

  6. Garvin Hicking updated the commit message in patch set 3 V +1 01/08/24, 21:53

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 01/08/24, 21:53

  8. core-ci voted on patch set 3 V +1 01/08/24, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51290

  9. Benni Mack voted on patch set 3 CR +1 V +1 01/09/24, 08:44

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 01/09/24, 08:46

  11. Stefan Bürk merged patch set 4 01/09/24, 09:14