Review main Merged

82362[TASK] Implement missing delete functionality for FileReference

Torben Hansen CR +2 V +2 Normal +70 −8 updated 01/07/24, 20:38

Commit message

When working with a `FileReference` object, it is currently not
possible to delete the file reference  with the `delete()`
method, since it has never been implemented.

The `delete()` functionality can however be useful when working
manually with file references.

This change implements the missing functionality.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Torben Hansen uploaded patch set 1 01/07/24, 13:45

  2. core-ci voted on patch set 1 V +1 01/07/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51183

  3. Christoph Lehmann voted on patch set 1 CR +1 01/07/24, 14:03

  4. Oliver Klee commented on patch set 1 01/07/24, 15:02

    Can we cover this with a (functional) test?
  5. Torben Hansen uploaded patch set 2 CR +1 V +1 01/07/24, 18:24

  6. Torben Hansen commented on patch set 2 01/07/24, 18:25

    Reply

    Added a test, which ensures that the file reference is deleted
  7. core-ci voted on patch set 2 V -1 01/07/24, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51185

  8. Torben Hansen uploaded patch set 3 V -1 01/07/24, 18:34

  9. core-ci voted on patch set 3 V +1 01/07/24, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51186

  10. Oliver Klee voted on patch set 3 CR +1 V +1 01/07/24, 19:19

  11. Benni Mack voted on patch set 3 CR +2 V +2 01/07/24, 20:38

  12. Benni Mack merged patch set 4 01/07/24, 20:38