Review main Merged

82396[BUGFIX] Add fake TS setup in admin panel for fluid

Benni Mack CR +2 V +2 Easy +26 −1 updated 01/29/24, 17:20

Commit message

With #100759, f:translate has been changed to use the
extbase LocalizationUtility in all scopes. This
triggers the ConfigurationManager, which fetches
TypoScript setup from the Request attribute.

But TS setup is never set in fully cached page content
scenarios and there is usually no Fluid view triggered
in this scope.

The admin panel however renders in "fully cached" as
well, which then fails when trying to fetch TS setup.

We *do* want extbase to fail in this scenario, since
TS is important for extbase configuration and it needs
to rely on TS setup being set in Frontend.

The patch thus works around the issue in admin panel
directly. The situation should resolve later again,
when work on LocalizationUtility finished.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Benni Mack uploaded patch set 1 01/08/24, 13:58

  2. core-ci voted on patch set 1 V -1 01/08/24, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51241

  3. Christian Kuhn commented on patch set 1 CR -1 01/08/24, 14:19

    FrontendConfigurationManager.php:182

    benni and me aligned that we fix this in ext:adminpanel instead since raising the exception here is important and should be kept.
  4. Christian Kuhn uploaded patch set 2 CR -1 V -1 01/29/24, 16:20

  5. Christian Kuhn commented on patch set 2 01/29/24, 16:21

    FrontendConfigurationManager.php:182 Reply

    Done
  6. Christian Kuhn updated the commit message in patch set 3 01/29/24, 16:22

  7. Christian Kuhn uploaded patch set 4 01/29/24, 16:23

  8. core-ci voted on patch set 2 V -1 01/29/24, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52441

  9. Christian Kuhn uploaded patch set 5 01/29/24, 16:34

  10. core-ci voted on patch set 5 V +1 01/29/24, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52444

  11. Christian Kuhn voted on patch set 5 CR +1 V +1 01/29/24, 17:01

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 01/29/24, 17:13

  13. Stefan Bürk voted on patch set 5 CR +2 V +2 01/29/24, 17:20

  14. Stefan Bürk merged patch set 6 01/29/24, 17:20