Review main Merged

82403[DOCS] Fix example in changelog for UsableForConnectionInterface

Chris Müller CR +2 V +2 Easy +1 −2 updated 01/08/24, 18:30

Commit message

As `canBeUsedForConnection()` is defined in the `UsableForConnectionInterface`, this interface must be implemented.
As it also extends the `\Doctrine\DBAL\Driver\Middleware` interface,
mentioning that interface can be omitted.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Chris Müller uploaded patch set 1 01/08/24, 18:00

  2. core-ci voted on patch set 1 V +1 01/08/24, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51276

  3. Oliver Klee updated the commit message in patch set 2 V +1 01/08/24, 18:08

  4. Oliver Klee voted on patch set 2 CR +1 V +1 01/08/24, 18:08

  5. core-ci voted on patch set 2 V +1 01/08/24, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51277

  6. Stefan Bürk voted on patch set 2 CR +2 V +2 01/08/24, 18:30

  7. Stefan Bürk merged patch set 3 01/08/24, 18:30