Review main Merged

82416[TASK] Avoid TSFE->contentPid, ->rootLine, ->page, ->id

Christian Kuhn CR +2 V +2 Expert +603 −549 updated 01/12/24, 11:55

Commit message

This removes usages of those properties from TSFE
that have been modeled as PageInformation object
attached to the Request as attribute
'frontend.page.information' with #102715.

The patch is relatively intrusive since especially
TSFE->page and TSFE->id were frequently consumed
properties.

It however allows us to reduce dependencies to TSFE
quite significantly, the number of calls to
$GLOBALS['TSFE'] shrinks.

It also shows that we still have a couple of constructs
that need to get the Request hand over, in particular
the data processors and more importantly the LinkFactory
and link builders: Those tend to either get the Request
using "parent" ContentObjectRenderer->getRequest() (that
method should be declared protected later) or from
$GLOBALS['TYPO3_REQUEST']. We accept this for now since
using $GLOBALS['TYPO3_REQUEST'] is at least less worse
than using $GLOBALS['TSFE']. A dedicated patch will resolve
that situation later, though.

Note most remaining use TSFE->config, especially
TSFE->config['config']. To model this in a good
way, we need a preparation within the TypoScript calculation
in getFromCache(), which will be a target of one of the
next patches.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 45

Show 25 more files

Review log 4172

Show 2447 earlier messages
  1. Christian Kuhn uploaded patch set 1 01/09/24, 16:31

  2. core-ci voted on patch set 1 V +1 01/09/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51344

  3. Christian Kuhn uploaded patch set 2 V +1 01/09/24, 17:19

  4. core-ci voted on patch set 2 V -1 01/09/24, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51346

  5. Christian Kuhn uploaded patch set 3 V -1 01/09/24, 17:37

  6. Christian Kuhn uploaded patch set 4 01/09/24, 17:39

  7. core-ci voted on patch set 3 V +1 01/09/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51348

  8. core-ci voted on patch set 4 V +1 01/09/24, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51349

  9. Christian Kuhn uploaded patch set 5 V +1 01/09/24, 18:29

  10. core-ci voted on patch set 5 V +1 01/09/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51351

  11. Christian Kuhn uploaded patch set 6 V +1 01/09/24, 18:35

  12. core-ci voted on patch set 6 V +1 01/09/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51352

  13. Christian Kuhn uploaded patch set 7 V +1 01/09/24, 22:16

  14. core-ci voted on patch set 7 V +1 01/09/24, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51358

  15. Christian Kuhn uploaded patch set 8 V +1 01/09/24, 22:36

  16. core-ci voted on patch set 8 V +1 01/09/24, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51359

  17. Christian Kuhn uploaded patch set 9 V +1 01/09/24, 22:47

  18. core-ci voted on patch set 9 V +1 01/09/24, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51360

  19. Christian Kuhn uploaded patch set 10 V +1 01/09/24, 23:17

  20. core-ci voted on patch set 10 V +1 01/09/24, 23:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51361

  21. Christian Kuhn uploaded patch set 11 V +1 01/09/24, 23:29

  22. core-ci voted on patch set 11 V +1 01/09/24, 23:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51362

  23. Christian Kuhn uploaded patch set 12 V +1 01/09/24, 23:51

  24. Christian Kuhn uploaded patch set 13 01/09/24, 23:55

  25. core-ci voted on patch set 12 V -1 01/09/24, 23:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51363

  26. Christian Kuhn uploaded patch set 14 01/09/24, 23:59

  27. core-ci voted on patch set 13 V +1 01/10/24, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51364

  28. Christian Kuhn uploaded patch set 15 01/10/24, 00:03

  29. core-ci voted on patch set 14 V +1 01/10/24, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51365

  30. core-ci voted on patch set 15 V +1 01/10/24, 00:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51366

  31. Christian Kuhn uploaded patch set 16 V +1 01/10/24, 00:30

  32. core-ci voted on patch set 16 V +1 01/10/24, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51367

  33. Christian Kuhn uploaded patch set 17 V +1 01/11/24, 11:31

  34. core-ci voted on patch set 17 V -1 01/11/24, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51437

  35. Christian Kuhn uploaded patch set 18 V -1 01/11/24, 13:25

  36. core-ci voted on patch set 18 V +1 01/11/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51441

  37. Christian Kuhn uploaded patch set 19 V +1 01/11/24, 13:45

  38. core-ci voted on patch set 19 V +1 01/11/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51442

  39. Christian Kuhn uploaded patch set 20 V +1 01/11/24, 13:57

  40. core-ci voted on patch set 20 V +1 01/11/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51444

  41. Christian Kuhn uploaded patch set 21 V +1 01/11/24, 15:13

  42. core-ci voted on patch set 21 V -1 01/11/24, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51449

  43. Christian Kuhn uploaded patch set 22 V -1 01/11/24, 15:36

  44. Christian Kuhn uploaded patch set 23 01/11/24, 15:38

  45. core-ci voted on patch set 22 V +1 01/11/24, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51450

  46. core-ci voted on patch set 23 V +1 01/11/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51451

  47. Christian Kuhn uploaded patch set 24 V +1 01/11/24, 16:42

  1. core-ci voted on patch set 24 V +1 01/11/24, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51455

  2. Christian Kuhn uploaded patch set 25 V +1 01/11/24, 20:26

  3. core-ci voted on patch set 25 V +1 01/11/24, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51458

  4. Christian Kuhn uploaded patch set 26 V +1 01/11/24, 21:35

  5. core-ci voted on patch set 26 V -1 01/11/24, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51460

  6. Christian Kuhn uploaded patch set 27 V -1 01/11/24, 22:19

  7. Benni Mack commented on patch set 27 01/11/24, 22:21

    RedirectService.php:412

    comment can be removed, I guess
  8. core-ci voted on patch set 27 V +1 01/11/24, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51463

  9. Christian Kuhn uploaded patch set 28 V +1 01/11/24, 22:51

  10. Christian Kuhn commented on patch set 27 01/11/24, 22:51

    RedirectService.php:412 Reply

    Done
  11. core-ci voted on patch set 28 V +1 01/11/24, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51467

  12. Christian Kuhn updated the commit message in patch set 29 V +1 01/11/24, 23:00

  13. Christian Kuhn updated the commit message in patch set 30 01/11/24, 23:01

  14. core-ci voted on patch set 29 V +1 01/11/24, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51468

  15. core-ci voted on patch set 30 V +1 01/11/24, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51469

  16. Benni Mack voted on patch set 30 CR +1 V +1 01/12/24, 10:48

  17. Nikita Hovratov commented on patch set 30 01/12/24, 10:53

    AdminPanelRenderer.php:38

    redundant readonly as class is readonly
  18. Christian Kuhn uploaded patch set 31 CR +1 V +1 01/12/24, 10:54

  19. Christian Kuhn commented on patch set 30 01/12/24, 10:55

    AdminPanelRenderer.php:38 Reply

    Done
  20. core-ci voted on patch set 31 V +1 01/12/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51491

  21. Nikita Hovratov commented on patch set 31 CR +1 V +1 01/12/24, 11:17

    great work
  22. Benni Mack voted on patch set 31 CR +1 V +1 01/12/24, 11:19

  23. Stefan Bürk voted on patch set 31 CR +1 V +1 01/12/24, 11:54

  24. Christian Kuhn voted on patch set 31 CR +2 V +2 01/12/24, 11:55

  25. Christian Kuhn merged patch set 32 01/12/24, 11:55