82416[TASK] Avoid TSFE->contentPid, ->rootLine, ->page, ->id
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 45
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+17 −22
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelRenderer.php2+9 −6
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+6 −23
- typo3/sysext/core/Classes/ExpressionLanguage/FunctionsProvider/Typo3ConditionFunctionsProvider.php+4 −0
- typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php+13 −17
- typo3/sysext/core/Tests/Functional/ExpressionLanguage/ResolverTest.php+2 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+9 −8
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+22 −11
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ActionViewHelperTest.php+6 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+6 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Transform/HtmlViewHelperTest.php+2 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ActionViewHelperTest.php+4 −6
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+7 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+5 −4
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+6 −21
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+0 −8
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.php+1 −15
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+18 −20
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+40 −32
Show 25 more files
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+9 −17
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+43 −63
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+17 −59
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+0 −1
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+6 −8
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+4 −5
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+5 −7
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+5 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+20 −5
- typo3/sysext/frontend/Configuration/Services.yaml+1 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+5 −2
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+7 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+7 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+172 −19
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+0 −12
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+19 −30
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+3 −7
- typo3/sysext/indexed_search/Classes/EventListener/FrontendGenerationPageIndexingTrigger.php+9 −4
- typo3/sysext/redirects/Classes/Service/RedirectService.php2+0 −5
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+44 −40
- typo3/sysext/seo/Classes/HrefLang/HrefLangGenerator.php+11 −19
- typo3/sysext/seo/Classes/MetaTag/MetaTagGenerator.php+22 −18
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php+2 −1
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+13 −10
Review log 4172
Show 2447 earlier messages
-
Christian Kuhn uploaded patch set 1 01/09/24, 16:31
-
core-ci voted on patch set 1 V +1 01/09/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51344
-
Christian Kuhn uploaded patch set 2
V +101/09/24, 17:19 -
core-ci voted on patch set 2 V -1 01/09/24, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51346
-
Christian Kuhn uploaded patch set 3
V -101/09/24, 17:37 -
Christian Kuhn uploaded patch set 4 01/09/24, 17:39
-
core-ci voted on patch set 3 V +1 01/09/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51348
-
core-ci voted on patch set 4 V +1 01/09/24, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51349
-
Christian Kuhn uploaded patch set 5
V +101/09/24, 18:29 -
core-ci voted on patch set 5 V +1 01/09/24, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51351
-
Christian Kuhn uploaded patch set 6
V +101/09/24, 18:35 -
core-ci voted on patch set 6 V +1 01/09/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51352
-
Christian Kuhn uploaded patch set 7
V +101/09/24, 22:16 -
core-ci voted on patch set 7 V +1 01/09/24, 22:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51358
-
Christian Kuhn uploaded patch set 8
V +101/09/24, 22:36 -
core-ci voted on patch set 8 V +1 01/09/24, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51359
-
Christian Kuhn uploaded patch set 9
V +101/09/24, 22:47 -
core-ci voted on patch set 9 V +1 01/09/24, 22:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51360
-
Christian Kuhn uploaded patch set 10
V +101/09/24, 23:17 -
core-ci voted on patch set 10 V +1 01/09/24, 23:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51361
-
Christian Kuhn uploaded patch set 11
V +101/09/24, 23:29 -
core-ci voted on patch set 11 V +1 01/09/24, 23:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51362
-
Christian Kuhn uploaded patch set 12
V +101/09/24, 23:51 -
Christian Kuhn uploaded patch set 13 01/09/24, 23:55
-
core-ci voted on patch set 12 V -1 01/09/24, 23:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51363
-
Christian Kuhn uploaded patch set 14 01/09/24, 23:59
-
core-ci voted on patch set 13 V +1 01/10/24, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51364
-
Christian Kuhn uploaded patch set 15 01/10/24, 00:03
-
core-ci voted on patch set 14 V +1 01/10/24, 00:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51365
-
core-ci voted on patch set 15 V +1 01/10/24, 00:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51366
-
Christian Kuhn uploaded patch set 16
V +101/10/24, 00:30 -
core-ci voted on patch set 16 V +1 01/10/24, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51367
-
Christian Kuhn uploaded patch set 17
V +101/11/24, 11:31 -
core-ci voted on patch set 17 V -1 01/11/24, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51437
-
Christian Kuhn uploaded patch set 18
V -101/11/24, 13:25 -
core-ci voted on patch set 18 V +1 01/11/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51441
-
Christian Kuhn uploaded patch set 19
V +101/11/24, 13:45 -
core-ci voted on patch set 19 V +1 01/11/24, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51442
-
Christian Kuhn uploaded patch set 20
V +101/11/24, 13:57 -
core-ci voted on patch set 20 V +1 01/11/24, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51444
-
Christian Kuhn uploaded patch set 21
V +101/11/24, 15:13 -
core-ci voted on patch set 21 V -1 01/11/24, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51449
-
Christian Kuhn uploaded patch set 22
V -101/11/24, 15:36 -
Christian Kuhn uploaded patch set 23 01/11/24, 15:38
-
core-ci voted on patch set 22 V +1 01/11/24, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51450
-
core-ci voted on patch set 23 V +1 01/11/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51451
-
Christian Kuhn uploaded patch set 24
V +101/11/24, 16:42
-
core-ci voted on patch set 24 V +1 01/11/24, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51455
-
Christian Kuhn uploaded patch set 25
V +101/11/24, 20:26 -
core-ci voted on patch set 25 V +1 01/11/24, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51458
-
Christian Kuhn uploaded patch set 26
V +101/11/24, 21:35 -
core-ci voted on patch set 26 V -1 01/11/24, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51460
-
Christian Kuhn uploaded patch set 27
V -101/11/24, 22:19 -
Benni Mack commented on patch set 27 01/11/24, 22:21
-
core-ci voted on patch set 27 V +1 01/11/24, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51463
-
Christian Kuhn uploaded patch set 28
V +101/11/24, 22:51 -
Christian Kuhn commented on patch set 27 01/11/24, 22:51
RedirectService.php:412ReplyDone -
core-ci voted on patch set 28 V +1 01/11/24, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51467
-
Christian Kuhn updated the commit message in patch set 29
V +101/11/24, 23:00 -
Christian Kuhn updated the commit message in patch set 30 01/11/24, 23:01
-
core-ci voted on patch set 29 V +1 01/11/24, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51468
-
core-ci voted on patch set 30 V +1 01/11/24, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51469
-
Benni Mack voted on patch set 30 CR +1 V +1 01/12/24, 10:48
-
Nikita Hovratov commented on patch set 30 01/12/24, 10:53
AdminPanelRenderer.php:38redundant readonly as class is readonly -
Christian Kuhn uploaded patch set 31
CR +1V +101/12/24, 10:54 -
Christian Kuhn commented on patch set 30 01/12/24, 10:55
AdminPanelRenderer.php:38ReplyDone -
core-ci voted on patch set 31 V +1 01/12/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51491
-
Nikita Hovratov commented on patch set 31 CR +1 V +1 01/12/24, 11:17
great work -
Benni Mack voted on patch set 31 CR +1 V +1 01/12/24, 11:19
-
Stefan Bürk voted on patch set 31 CR +1 V +1 01/12/24, 11:54
-
Christian Kuhn voted on patch set 31 CR +2 V +2 01/12/24, 11:55
-
Christian Kuhn merged patch set 32 01/12/24, 11:55
RedirectService.php:412