82420[BUGFIX] Allow falsy novalidate attribute in form VH
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 67
-
Sascha Egerer uploaded patch set 1 01/10/24, 10:45
-
core-ci voted on patch set 1 V +1 01/10/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51380
-
Simon Schaufelberger commented on patch set 1 01/10/24, 22:58
-
Simon Schaufelberger commented on patch set 1 01/10/24, 22:59
FormViewHelper.php:167why is this not working with the original code and why does it need to be removed even though it was never added? -
Sascha Egerer commented on patch set 1 01/10/24, 23:08
FormViewHelper.php:167Reply UnresolvedFormViewHelper is a TagBased viewhelper and the attribute is added by $this->registerTagAttribute('novalidate', 'bool', 'Indicate that the form is not to be validated on submit.'); So as soon as the attribute is defined in when calling the viewhelper i'll be added. As only the existance of the attribute is required for HTML it'll break if you define a falsy value and expect the attribute to not be set. -
Christian Kuhn commented on patch set 1 08/06/24, 15:32
hey. i hope it is ok to abandon here for now: mid-term, we're planing to support 'boolean' attributes in fluid standalone. short term, templates should either fully set the attribute, or skip it. -
Christian Kuhn abandoned the change 08/06/24, 15:32
Unresolved