Review main Merged

82437[TASK] Harmonize tests around PageRepository->init

Benni Mack CR +2 V +2 Easy +21 −25 updated 01/11/24, 21:16

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Benni Mack uploaded patch set 1 01/11/24, 13:48

  2. core-ci voted on patch set 1 V +1 01/11/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51443

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 01/11/24, 15:36

  4. Christian Kuhn commented on patch set 1 CR +1 V +1 01/11/24, 21:13

    RootlineUtility.php:108

    I tend to hand over the context explicitly for such methods to avoid the call to $this->context in the detail method, making the dependency more obvious. But that's a bit matter-of-taste and could be changed later again.
  5. Benni Mack voted on patch set 1 CR +2 V +2 01/11/24, 21:16

  6. Benni Mack merged patch set 2 01/11/24, 21:16