Review main Merged

82446[BUGFIX] Do not create integer field for TCA selectSingle with no items

Nikita Hovratov CR +2 V +2 Easy +28 −1 updated 01/14/24, 09:07

Commit message

In case of a type `select` and renderType `selectSingle` TCA field,
which doesn't define `items` nor `itemsProcFunc`, TcaSchema would always
generate a type integer db field. This should rather fall back to
varchar as the type can not be assumed properly. Exception: If
foreign_table is defined then we know the values are uids.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Nikita Hovratov uploaded patch set 1 01/12/24, 12:38

  2. core-ci voted on patch set 1 V +1 01/12/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51498

  3. Oliver Klee commented on patch set 1 01/12/24, 12:44

    Can we cover this with a test?
  4. Nikita Hovratov uploaded patch set 2 V +1 01/12/24, 12:56

  5. Nikita Hovratov commented on patch set 2 01/12/24, 12:57

    Reply

    Thanks, I forgot :)
  6. core-ci voted on patch set 2 V +1 01/12/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51502

  7. Oliver Klee voted on patch set 2 CR +1 V +1 01/12/24, 13:03

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 01/13/24, 01:36

  9. Anja Leichsenring voted on patch set 2 CR +2 V +2 01/14/24, 09:07

  10. Anja Leichsenring merged patch set 3 01/14/24, 09:07