82452[TASK] Streamline TypoScriptFrontendItitialization
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 27
- typo3/sysext/core/Classes/Context/Context.php+1 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+4 −4
- typo3/sysext/core/Classes/Error/Http/StatusException.php+2 −0
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+1 −1
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+8 −1
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+0 −5
- typo3/sysext/frontend/Classes/Controller/ErrorController.php+2 −2
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −27
- typo3/sysext/frontend/Classes/Event/AfterPageAndLanguageIsResolvedEvent.php+3 −2
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+23 −4
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+40 −701
- typo3/sysext/frontend/Classes/Page/PageInformationCreationFailedException.phpnew+43 −0
- typo3/sysext/frontend/Classes/Page/PageInformationFactory.phpnew+560 −0
- typo3/sysext/frontend/Configuration/Services.yaml+0 −4
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/typoScriptFrontendInitializationBeUsers.csvnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/typoScriptFrontendInitializationCases.csvnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/typoScriptFrontendInitializationFeGroupsFeUsers.csvnew+8 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/typoScriptFrontendInitializationSysTemplate.csvnew+7 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/TypoScriptFrontendInitializationTest.phpnew+226 −0
Show 7 more files
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+2 −2
- typo3/sysext/redirects/Classes/Service/RedirectService.php+7 −9
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+2 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+3 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+31 −2
- typo3/sysext/workspaces/Configuration/RequestMiddlewares.php+1 −1
Review log 3566
Show 2141 earlier messages
-
Christian Kuhn uploaded patch set 1 01/13/24, 15:20
-
core-ci voted on patch set 1 V -1 01/13/24, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51536
-
Christian Kuhn uploaded patch set 2
V -101/15/24, 12:39 -
core-ci voted on patch set 2 V -1 01/15/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51580
-
Christian Kuhn uploaded patch set 3
V -101/15/24, 13:29 -
core-ci voted on patch set 3 V +1 01/15/24, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51582
-
Christian Kuhn uploaded patch set 4
V +101/15/24, 14:08 -
core-ci voted on patch set 4 V +1 01/15/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51583
-
Christian Kuhn uploaded patch set 5
V +101/15/24, 14:27 -
core-ci voted on patch set 5 V +1 01/15/24, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51584
-
Christian Kuhn uploaded patch set 6
V +101/15/24, 16:24 -
core-ci voted on patch set 6 V +1 01/15/24, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51595
-
Christian Kuhn uploaded patch set 7
V +101/15/24, 17:06 -
core-ci voted on patch set 7 V -1 01/15/24, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51596
-
Christian Kuhn uploaded patch set 8
V -101/15/24, 17:42 -
core-ci voted on patch set 8 V +1 01/15/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51598
-
Christian Kuhn uploaded patch set 9
V +101/16/24, 11:09 -
core-ci voted on patch set 9 V -1 01/16/24, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51634
-
Christian Kuhn uploaded patch set 10
V -101/16/24, 11:37 -
core-ci voted on patch set 10 V +1 01/16/24, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51635
-
Christian Kuhn uploaded patch set 11
V +101/16/24, 14:28 -
core-ci voted on patch set 11 V +1 01/16/24, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51646
-
Christian Kuhn uploaded patch set 12
V +101/16/24, 15:03 -
core-ci voted on patch set 12 V -1 01/16/24, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51652
-
Christian Kuhn uploaded patch set 13
V -101/16/24, 15:34 -
core-ci voted on patch set 13 V +1 01/16/24, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51653
-
Christian Kuhn uploaded patch set 14
V +101/16/24, 15:54 -
core-ci voted on patch set 14 V +1 01/16/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51654
-
Christian Kuhn uploaded patch set 15
V +101/16/24, 16:06 -
core-ci voted on patch set 15 V -1 01/16/24, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51655
-
Christian Kuhn uploaded patch set 16
V -101/16/24, 17:08 -
core-ci voted on patch set 16 V -1 01/16/24, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51656
-
Christian Kuhn uploaded patch set 17
V -101/16/24, 17:20 -
core-ci voted on patch set 17 V -1 01/16/24, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51657
-
Christian Kuhn uploaded patch set 18
V -101/16/24, 17:29 -
core-ci voted on patch set 18 V +1 01/16/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51658
-
Christian Kuhn uploaded patch set 19
V +101/16/24, 18:08 -
core-ci voted on patch set 19 V -1 01/16/24, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51659
-
Christian Kuhn uploaded patch set 20
V -101/16/24, 18:15 -
core-ci voted on patch set 20 V +1 01/16/24, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51660
-
Christian Kuhn rebased onto patch set 21
V +101/17/24, 10:19
-
core-ci voted on patch set 21 V +1 01/17/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51676
-
Christian Kuhn uploaded patch set 22
V +101/17/24, 15:27 -
core-ci voted on patch set 22 V -1 01/17/24, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51697
-
Christian Kuhn uploaded patch set 23
V -101/17/24, 17:07 -
Christian Kuhn uploaded patch set 24 01/17/24, 17:09
-
core-ci voted on patch set 23 V -1 01/17/24, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51703
-
core-ci voted on patch set 24 V +1 01/17/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51704
-
Christian Kuhn uploaded patch set 25
V +101/18/24, 08:48 -
core-ci voted on patch set 25 V +1 01/18/24, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51725
-
Christian Kuhn uploaded patch set 26
V +101/18/24, 09:09 -
Christian Kuhn updated the commit message in patch set 27 01/18/24, 09:12
-
core-ci voted on patch set 26 V +1 01/18/24, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51727
-
Christian Kuhn updated the commit message in patch set 28 01/18/24, 09:16
-
core-ci voted on patch set 27 V +1 01/18/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51728
-
Christian Kuhn updated the commit message in patch set 29 01/18/24, 09:18
-
Christian Kuhn updated the commit message in patch set 30 01/18/24, 09:21
-
core-ci voted on patch set 28 V +1 01/18/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51729
-
Christian Kuhn uploaded patch set 31 01/18/24, 09:24
-
core-ci voted on patch set 29 V +1 01/18/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51730
-
core-ci voted on patch set 30 V +1 01/18/24, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51731
-
core-ci voted on patch set 31 V +1 01/18/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51732
-
Stefan Bürk voted on patch set 31 CR +1 V +1 01/18/24, 10:40
-
Benni Mack commented on patch set 31 CR +1 V +1 01/18/24, 11:02
I think this is a great step forward. In general, I think we should try to move the errorController out of the factory and into the middleware, and instead throw customized Exceptions with the error code + message in it to create the response in the middleware - but that is the icing on the cake, not directly relevant for this change. Thanks for the tests -
Christian Kuhn commented on patch set 31 CR +2 V +2 01/18/24, 11:32
Reply
Yeah, I guess we could do this. But I guess its fine as is for now and we could do that later as well, the introduced exception is internal and could very well carry code and message data instead of the response. We can rethink after the ext:redirect RedirectService hack has been resolved, I suppose. -
Christian Kuhn merged patch set 32 01/18/24, 11:32