Review main Merged Breaking

82455[!!!][FEATURE] Add PSR-14 Events to TypoLinkCodecService

Oli Bartsch CR +2 V +2 Hard +572 −15 updated 01/18/24, 20:19

Commit message

This adds two new PSR-14 Events to the TypoLinkCodecService,
which allow to easily manipulate the encoding and decoding
functionality of  TypoLink's without the need of extending
/ cross classing.

Additionally, this allows to make the service "final readonly"
and to apply strict typing.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 2839

Show 814 earlier messages
  1. Oli Bartsch uploaded patch set 1 01/14/24, 15:29

  2. core-ci voted on patch set 1 V -1 01/14/24, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51554

  3. Oli Bartsch uploaded patch set 2 V -1 01/15/24, 09:47

  4. Oli Bartsch uploaded patch set 3 01/15/24, 10:12

  5. Oli Bartsch uploaded patch set 4 01/15/24, 10:19

  6. core-ci voted on patch set 2 V -1 01/15/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51569

  7. core-ci voted on patch set 3 V -1 01/15/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51572

  8. core-ci voted on patch set 4 V -1 01/15/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51573

  9. core-ci commented on patch set 4 01/15/24, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51573

  10. Oli Bartsch uploaded patch set 5 V -1 01/15/24, 15:34

  11. Oli Bartsch updated the commit message in patch set 6 01/15/24, 15:37

  12. Oli Bartsch uploaded patch set 7 01/15/24, 16:03

  13. core-ci voted on patch set 7 V +1 01/15/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51594

  14. Christian Kuhn commented on patch set 7 01/15/24, 16:28

    TypoLinkCodecService.php:72

    please DI EventDispatcherInterface
  1. Oli Bartsch uploaded patch set 8 V +1 01/15/24, 20:24

  2. core-ci voted on patch set 8 V -1 01/15/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51606

  3. Oli Bartsch uploaded patch set 9 V -1 01/15/24, 21:05

  4. core-ci voted on patch set 9 V +1 01/15/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51608

  5. Oli Bartsch commented on patch set 9 01/15/24, 21:42

    TypoLinkCodecService.php:72 Reply

    Done
  6. Stefan Bürk commented on patch set 9 01/17/24, 02:19

    Issue number is missing
  7. Oli Bartsch updated the commit message in patch set 10 V +1 01/17/24, 10:07

  8. Oli Bartsch commented on patch set 10 01/17/24, 10:08

    Reply

    Got lost in patchset 7 .. ¯\_(ツ)_/¯
  9. core-ci voted on patch set 10 V +1 01/17/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51675

  10. Benni Mack commented on patch set 10 01/17/24, 23:05

    TypoLinkCodecService.php:39

    do we need to set this to readonly when the whole class is readonly?
  11. Simon Schaufelberger commented on patch set 10 01/18/24, 02:00

    Breaking-102835-StrictTypingInFinalTypoLinkCodecService.rst:15

    without '
  12. Oli Bartsch uploaded patch set 11 V +1 01/18/24, 08:21

  13. Oli Bartsch commented on patch set 11 01/18/24, 08:21

    TypoLinkCodecService.php:39 Reply

    Done

    Breaking-102835-StrictTypingInFinalTypoLinkCodecService.rst:15 Reply

    Done
  14. core-ci voted on patch set 11 V +1 01/18/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51723

  15. Christian Kuhn voted on patch set 11 CR +1 V +1 01/18/24, 10:56

  16. Benni Mack voted on patch set 11 CR +1 V +1 01/18/24, 13:39

  17. Benni Mack voted on patch set 11 CR +2 01/18/24, 13:39

  18. Benni Mack voted on patch set 11 V +2 01/18/24, 13:39

  19. Benni Mack voted on patch set 11 CR +1 V +1 01/18/24, 13:39

  20. Oli Bartsch uploaded patch set 12 CR +1 V +1 01/18/24, 15:14

  21. core-ci voted on patch set 12 V +1 01/18/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51767

  22. Benni Mack voted on patch set 12 CR +1 V +1 01/18/24, 15:28

  23. Christian Kuhn voted on patch set 12 CR +1 V +1 01/18/24, 15:52

  24. Oli Bartsch voted on patch set 12 CR +2 V +2 01/18/24, 20:19

  25. Oli Bartsch merged patch set 13 01/18/24, 20:19