82455[!!!][FEATURE] Add PSR-14 Events to TypoLinkCodecService
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Classes/LinkHandling/Event/AfterTypoLinkDecodedEvent.phpnew+56 −0
- typo3/sysext/core/Classes/LinkHandling/Event/BeforeTypoLinkEncodedEvent.phpnew+56 −0
- typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php4+32 −6
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102835-StrictTypingInFinalTypoLinkCodecService.rst2new+52 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102835-AddPSR-14EventsToManipulateTypoLinkCodecService.rstnew+78 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SoftReference/TypoLinkSoftReferenceParserTest.php+11 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/Event/AfterTypoLinkDecodedEventTest.phpnew+88 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/Event/BeforeTypoLinkEncodedEventTest.phpnew+100 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/TypoLinkCodecServiceTest.php+75 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+3 −2
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+12 −0
Review log 2839
Show 814 earlier messages
-
Oli Bartsch uploaded patch set 1 01/14/24, 15:29
-
core-ci voted on patch set 1 V -1 01/14/24, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51554
-
Oli Bartsch uploaded patch set 2
V -101/15/24, 09:47 -
Oli Bartsch uploaded patch set 3 01/15/24, 10:12
-
Oli Bartsch uploaded patch set 4 01/15/24, 10:19
-
core-ci voted on patch set 2 V -1 01/15/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51569
-
core-ci voted on patch set 3 V -1 01/15/24, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51572
-
core-ci voted on patch set 4 V -1 01/15/24, 11:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51573
-
core-ci commented on patch set 4 01/15/24, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51573
-
Oli Bartsch uploaded patch set 5
V -101/15/24, 15:34 -
Oli Bartsch updated the commit message in patch set 6 01/15/24, 15:37
-
Oli Bartsch uploaded patch set 7 01/15/24, 16:03
-
core-ci voted on patch set 7 V +1 01/15/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51594
-
Christian Kuhn commented on patch set 7 01/15/24, 16:28
-
Oli Bartsch uploaded patch set 8
V +101/15/24, 20:24 -
core-ci voted on patch set 8 V -1 01/15/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51606
-
Oli Bartsch uploaded patch set 9
V -101/15/24, 21:05 -
core-ci voted on patch set 9 V +1 01/15/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51608
-
Oli Bartsch commented on patch set 9 01/15/24, 21:42
TypoLinkCodecService.php:72ReplyDone -
Stefan Bürk commented on patch set 9 01/17/24, 02:19
Issue number is missing -
Oli Bartsch updated the commit message in patch set 10
V +101/17/24, 10:07 -
Oli Bartsch commented on patch set 10 01/17/24, 10:08
Reply
Got lost in patchset 7 .. ¯\_(ツ)_/¯ -
core-ci voted on patch set 10 V +1 01/17/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51675
-
Benni Mack commented on patch set 10 01/17/24, 23:05
TypoLinkCodecService.php:39do we need to set this to readonly when the whole class is readonly? -
Simon Schaufelberger commented on patch set 10 01/18/24, 02:00
Breaking-102835-StrictTypingInFinalTypoLinkCodecService.rst:15without ' -
Oli Bartsch uploaded patch set 11
V +101/18/24, 08:21 -
Oli Bartsch commented on patch set 11 01/18/24, 08:21
TypoLinkCodecService.php:39ReplyDoneBreaking-102835-StrictTypingInFinalTypoLinkCodecService.rst:15ReplyDone -
core-ci voted on patch set 11 V +1 01/18/24, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51723
-
Christian Kuhn voted on patch set 11 CR +1 V +1 01/18/24, 10:56
-
Benni Mack voted on patch set 11 CR +1 V +1 01/18/24, 13:39
-
Benni Mack voted on patch set 11 CR +2 01/18/24, 13:39
-
Benni Mack voted on patch set 11 V +2 01/18/24, 13:39
-
Benni Mack voted on patch set 11 CR +1 V +1 01/18/24, 13:39
-
Oli Bartsch uploaded patch set 12
CR +1V +101/18/24, 15:14 -
core-ci voted on patch set 12 V +1 01/18/24, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51767
-
Benni Mack voted on patch set 12 CR +1 V +1 01/18/24, 15:28
-
Christian Kuhn voted on patch set 12 CR +1 V +1 01/18/24, 15:52
-
Oli Bartsch voted on patch set 12 CR +2 V +2 01/18/24, 20:19
-
Oli Bartsch merged patch set 13 01/18/24, 20:19
TypoLinkCodecService.php:72