Review main Abandoned

82457[FEATURE] Make InlineControlContainer::deleteRecord() public

Daniel Siepmann CR 0 V 0 Normal +68 −28 updated 02/01/24, 13:28

Commit message

This JavaScript API was private as this is a callback for deleting IRRE
children for files via delete button.
But it is possible to add custom controls and some might need to delete
a child in order to replace it with a different child through custom
controls.
Therefore this API is now made public to allow solving such use cases.
The API is available through the custom HTML element.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 811

  1. Daniel Siepmann uploaded patch set 1 01/15/24, 11:03

  2. core-ci voted on patch set 1 V -1 01/15/24, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51576

  3. Daniel Siepmann uploaded patch set 2 V -1 01/15/24, 11:11

  4. core-ci voted on patch set 2 V +1 01/15/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51577

  5. Daniel Siepmann marked it work in progress 01/15/24, 11:27

  6. Daniel Siepmann uploaded patch set 3 V +1 01/15/24, 11:41

  7. core-ci voted on patch set 3 V +1 01/15/24, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51579

  8. Daniel Siepmann commented on patch set 3 01/15/24, 11:47

    This change is ready for review.
  9. Daniel Siepmann commented on patch set 3 01/17/24, 16:17

    Another idea would be to use messages again?
  10. Andreas Kienast commented on patch set 3 01/23/24, 07:40

  11. Daniel Siepmann abandoned the change 02/01/24, 13:28

    In favour of the better approach in https://review.typo3.org/c/Packages/TYPO3.CMS/+/82594