82462[BUGFIX] Use correct check and fallback type for plugin itemGroups resolving
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1521
-
Oli Bartsch uploaded patch set 1 01/15/24, 20:58
-
core-ci voted on patch set 1 V +1 01/15/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51607
-
Oli Bartsch uploaded patch set 2
V +101/15/24, 21:07 -
core-ci voted on patch set 2 V +1 01/15/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51609
-
Nikita Hovratov commented on patch set 2 01/15/24, 21:31
-
Nikita Hovratov updated the commit message in patch set 3
V +101/15/24, 21:32 -
core-ci voted on patch set 3 V +1 01/15/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51611
-
Oli Bartsch uploaded patch set 4
V +101/15/24, 21:38 -
Oli Bartsch commented on patch set 4 01/15/24, 21:38
ExtensionManagementUtilityTest.php:1287ReplyDone -
Oli Bartsch uploaded patch set 5 01/15/24, 21:39
-
core-ci voted on patch set 4 V -1 01/15/24, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51612
-
Nikita Hovratov voted on patch set 5 CR +1 V +1 01/15/24, 21:42
-
core-ci voted on patch set 5 V +1 01/15/24, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51613
-
Oliver Klee commented on patch set 5 01/15/24, 22:01
Trivial nitpick: There should be no comma in the sentence.ExtensionManagementUtility.php:856We now have the `$selectItem->getGroup()` call 4 times if I am not mistaken. Maybe we can refactor a bit her and use a local variable to reduce duplication.ExtensionManagementUtilityTest.php:1289Please let’s be as strict as possible here and use the type-safe `assertSame` instead. -
Oli Bartsch uploaded patch set 6
CR +1V +101/15/24, 22:10 -
Oli Bartsch commented on patch set 6 01/15/24, 22:11
Reply
DoneExtensionManagementUtility.php:856ReplyDoneExtensionManagementUtilityTest.php:1289ReplyDone -
core-ci voted on patch set 6 V +1 01/15/24, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51614
-
Nikita Hovratov voted on patch set 6 CR +1 V +1 01/15/24, 22:26
-
Oliver Klee voted on patch set 6 CR +1 V +1 01/16/24, 09:51
-
Oli Bartsch voted on patch set 6 CR +2 V +2 01/16/24, 10:34
-
Oli Bartsch merged patch set 7 01/16/24, 10:34
ExtensionManagementUtilityTest.php:1287