Review main Merged

82462[BUGFIX] Use correct check and fallback type for plugin itemGroups resolving

Oli Bartsch CR +2 V +2 Easy +41 −3 updated 01/16/24, 10:34

Commit message

In case a plugin, using the `list` CType has
an item group configured, which is not defined
in `list_type>config>itemGroups`, EMU::addPlugin()
tries to get the label from the `CType>config>itemGroups`
definition.

This does now properly work by using the
correct array access in the if clause as
well as the correct fallback value in case
the defined item group does not exists in
`CType>config>itemGroups`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1521

  1. Oli Bartsch uploaded patch set 1 01/15/24, 20:58

  2. core-ci voted on patch set 1 V +1 01/15/24, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51607

  3. Oli Bartsch uploaded patch set 2 V +1 01/15/24, 21:07

  4. core-ci voted on patch set 2 V +1 01/15/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51609

  5. Nikita Hovratov commented on patch set 2 01/15/24, 21:31

    ExtensionManagementUtilityTest.php:1287

    Let's not set this at all, if both don't exist. This way FormEngine falls back to the identifier.
  6. Nikita Hovratov updated the commit message in patch set 3 V +1 01/15/24, 21:32

  7. core-ci voted on patch set 3 V +1 01/15/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51611

  8. Oli Bartsch uploaded patch set 4 V +1 01/15/24, 21:38

  9. Oli Bartsch commented on patch set 4 01/15/24, 21:38

    ExtensionManagementUtilityTest.php:1287 Reply

    Done
  10. Oli Bartsch uploaded patch set 5 01/15/24, 21:39

  11. core-ci voted on patch set 4 V -1 01/15/24, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51612

  12. Nikita Hovratov voted on patch set 5 CR +1 V +1 01/15/24, 21:42

  13. core-ci voted on patch set 5 V +1 01/15/24, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51613

  14. Oliver Klee commented on patch set 5 01/15/24, 22:01

    Trivial nitpick: There should be no comma in the sentence.

    ExtensionManagementUtility.php:856

    We now have the `$selectItem->getGroup()` call 4 times if I am not mistaken. Maybe we can refactor a bit her and use a local variable to reduce duplication.

    ExtensionManagementUtilityTest.php:1289

    Please let’s be as strict as possible here and use the type-safe `assertSame` instead.
  15. Oli Bartsch uploaded patch set 6 CR +1 V +1 01/15/24, 22:10

  16. Oli Bartsch commented on patch set 6 01/15/24, 22:11

    Reply

    Done

    ExtensionManagementUtility.php:856 Reply

    Done

    ExtensionManagementUtilityTest.php:1289 Reply

    Done
  17. core-ci voted on patch set 6 V +1 01/15/24, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51614

  18. Nikita Hovratov voted on patch set 6 CR +1 V +1 01/15/24, 22:26

  19. Oliver Klee voted on patch set 6 CR +1 V +1 01/16/24, 09:51

  20. Oli Bartsch voted on patch set 6 CR +2 V +2 01/16/24, 10:34

  21. Oli Bartsch merged patch set 7 01/16/24, 10:34