Review 12.4 Merged

82478[BUGFIX] Prevent type error on static route

Benjamin Franzke CR +2 V +2 Easy +3 −0 updated 01/18/24, 08:12

Commit message

If you happen to have inconsistent data in the
config.yaml like:

```
routes:
  -
    route: robots.txt
    type: staticText
    source: 'EXT:my_sitepackage_mysite/Resources/Public/robots.txt'
```

Currently a PHP type error is thrown instead of a proper exception.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 01/18/24, 08:06

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 01/18/24, 08:07

  3. core-ci voted on patch set 1 V +1 01/18/24, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51722

  4. Benjamin Franzke merged patch set 2 01/18/24, 08:12