Review main Merged

82505[TASK] Ensure unique values in filemounts permissions

Marcin Sągol CR +2 V +2 Easy +1 −0 updated 01/19/24, 20:26

Commit message

Ensure unique values in BackendUserAuthentication::groupData['filemounts']
by processing it through the StringUtility::uniqueList() function.

Prior to this change, values were not always unique due to the
combination of permissions for backend users and groups.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Marcin Sągol uploaded patch set 1 01/18/24, 09:49

  2. core-ci voted on patch set 1 V -1 01/18/24, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51735

  3. Marcin Sągol updated the commit message in patch set 2 V -1 01/18/24, 10:33

  4. core-ci voted on patch set 2 V +1 01/18/24, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51740

  5. Oli Bartsch voted on patch set 2 CR +1 V +1 01/18/24, 10:57

  6. Guido Schmechel voted on patch set 2 CR +1 01/19/24, 09:00

  7. Oliver Klee voted on patch set 2 CR +1 01/19/24, 09:04

  8. Benni Mack voted on patch set 2 CR +2 V +2 01/19/24, 20:26

  9. Benni Mack merged patch set 3 01/19/24, 20:26