Review main Merged Breaking

82506[!!!][FEATURE] Add PSR-14 Event to modify link resolving result data

Oli Bartsch CR +2 V +2 Hard +384 −50 updated 01/22/24, 15:14

Commit message

This introduces the new PSR-14
`AfterLinkResolvedByStringRepresentationEvent`, enabling extension
authors to modify the resolved link result data.

The event is dispatched by `LinkService->resolveByStringRepresentation()`
after existing handlers have been executed.

Therefore, in contrast to the previously available hook
`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['Link']['resolveByStringRepresentation']`
does the new event allow to even modify the resolved link
result data of the existing handlers and also cases where
the `UnknownLinkHandlerException` would have been thrown.

The corresponding exception is also added to the event
to provide as much information as possible.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2436

Show 711 earlier messages
  1. Oli Bartsch uploaded patch set 1 01/18/24, 10:12

  2. core-ci voted on patch set 1 V -1 01/18/24, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51737

  3. Oli Bartsch uploaded patch set 2 V -1 01/18/24, 10:30

  4. core-ci voted on patch set 2 V -1 01/18/24, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51739

  5. core-ci commented on patch set 2 01/18/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51739

  6. Oli Bartsch uploaded patch set 3 V -1 01/18/24, 11:01

  7. core-ci voted on patch set 3 V +1 01/18/24, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51741

  8. Benni Mack voted on patch set 3 CR +1 V +1 01/18/24, 13:37

  9. Benni Mack commented on patch set 3 CR 0 V 0 01/18/24, 13:38

    LinkService.php:144

    Actually, I wonder if we should have a huge try / catch around this method, so we could call the Event at all times?
  10. Oli Bartsch commented on patch set 3 01/18/24, 14:07

    LinkService.php:144 Reply

    I don't quite understand what you mean. The event is already called all the time.
  11. Benni Mack commented on patch set 3 01/18/24, 15:37

    LinkService.php:144 Reply

    see line 125
  1. Oli Bartsch uploaded patch set 4 V +1 01/19/24, 09:52

  2. core-ci voted on patch set 4 V -1 01/19/24, 09:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51794

  3. Oli Bartsch uploaded patch set 5 V -1 01/19/24, 10:00

  4. Oli Bartsch uploaded patch set 6 01/19/24, 10:02

  5. core-ci voted on patch set 6 V -1 01/19/24, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51798

  6. Oli Bartsch uploaded patch set 7 V -1 01/19/24, 10:23

  7. core-ci voted on patch set 7 V +1 01/19/24, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51801

  8. Oli Bartsch commented on patch set 7 01/19/24, 10:29

    LinkService.php:144 Reply

    Done
  9. Oli Bartsch uploaded patch set 8 V +1 01/19/24, 10:46

  10. Oli Bartsch uploaded patch set 9 01/19/24, 10:48

  11. core-ci voted on patch set 8 V -1 01/19/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51803

  12. core-ci voted on patch set 9 V +1 01/19/24, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51804

  13. Oli Bartsch updated the commit message in patch set 10 V +1 01/19/24, 11:04

  14. core-ci voted on patch set 10 V +1 01/19/24, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51806

  15. Benni Mack voted on patch set 10 CR +1 V +1 01/19/24, 20:14

  16. Oli Bartsch uploaded patch set 11 CR +1 V +1 01/21/24, 21:15

  17. Benni Mack voted on patch set 11 CR +1 V +1 01/21/24, 21:16

  18. core-ci voted on patch set 11 V +1 01/21/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51904

  19. Andreas Kienast commented on patch set 11 CR -1 01/22/24, 14:48

    on it
  20. Andreas Kienast uploaded patch set 12 CR +1 V +1 01/22/24, 14:56

  21. Andreas Kienast voted on patch set 12 CR +1 V +1 01/22/24, 14:56

  22. core-ci voted on patch set 12 V +1 01/22/24, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51940

  23. Benni Mack voted on patch set 12 CR +1 V +1 01/22/24, 15:11

  24. Oli Bartsch voted on patch set 12 CR +2 V +2 01/22/24, 15:14

  25. Oli Bartsch merged patch set 13 01/22/24, 15:14