Review 12.4 Merged

82507[BUGFIX] Restore `Controller` PHP attribute

Oli Bartsch CR +2 V +2 Normal +138 −110 updated 01/18/24, 13:10

Commit message

Instead of using a class alias for the `Controller`
PHP attribute, is the class now restored.

This allows to install TYPO3 even without enabling the
`typo3/class-alias-loader` composer plugin when the deprecated
`Controller` attribute is used by an extensions. We also adapt our
codebase to use the newer `AsController` attribute as an example
for extensions authors that copy code from the sourcetree.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Josef Glatz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Josef Glatz +1
    • core-ci +1 CI

Issues 2

Files 57

Show 37 more files

Review log 911

  1. Oli Bartsch uploaded patch set 1 01/18/24, 10:26

  2. core-ci voted on patch set 1 V +1 01/18/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51738

  3. Andreas Kienast commented on patch set 1 CR -1 01/18/24, 10:37

    Shouldn't this go into main as well? The old attribute is just deprecated there but the issue will remain the same.
  4. Oli Bartsch commented on patch set 1 01/18/24, 10:42

    Reply

    In v13, TYPO3 Core does not use the Controller attribute itself.
  5. Andreas Kienast voted on patch set 1 CR 0 01/18/24, 10:56

  6. Benjamin Franzke uploaded patch set 2 V +1 01/18/24, 12:54

  7. Benjamin Franzke commented on patch set 2 01/18/24, 12:54

    Reply

    Now I know what the issue in v12 is: We use the `#[Controller]` attribute in our *own* code (the change on `main` changed those), although it is deprecated. That caused the issue for Josef, despite no extension used the deprecated attribute. That means we should also switch these to to use `#[AsController]`: ``` git grep -l "#\[Controller\]" | grep Classes/ typo3/sysext/backend/Classes/Controller/AboutController.php typo3/sysext/backend/Classes/Controller/AjaxLoginController.php typo3/sysext/backend/Classes/Controller/BackendController.php typo3/sysext/backend/Classes/Controller/ClipboardController.php typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php typo3/sysext/backend/Classes/Controller/DummyController.php typo3/sysext/backend/Classes/Controller/EditDocumentController.php typo3/sysext/backend/Classes/Controller/ElementBrowserController.php typo3/sysext/backend/Classes/Controller/File/FileController.php typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php typo3/sysext/backend/Classes/Controller/LinkController.php typo3/sysext/backend/Classes/Controller/LiveSearchController.php typo3/sysext/backend/Classes/Controller/LoginController.php typo3/sysext/backend/Classes/Controller/LogoutController.php typo3/sysext/backend/Classes/Controller/MfaAjaxController.php typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php typo3/sysext/backend/Classes/Controller/MfaController.php typo3/sysext/backend/Classes/Controller/MfaSetupController.php typo3/sysext/backend/Classes/Controller/NewRecordController.php typo3/sysext/backend/Classes/Controller/OnlineMediaController.php typo3/sysext/backend/Classes/Controller/Page/MovePageController.php typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php typo3/sysext/backend/Classes/Controller/PageLayoutController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php typo3/sysext/backend/Classes/Controller/RecordListController.php typo3/sysext/backend/Classes/Controller/RecordListDownloadController.php typo3/sysext/backend/Classes/Controller/ResetPasswordController.php typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php typo3/sysext/backend/Classes/Controller/ShortcutController.php typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php typo3/sysext/backend/Classes/Controller/SwitchUserController.php typo3/sysext/backend/Classes/Controller/SystemInformationController.php typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php typo3/sysext/reactions/Classes/Controller/ManagementController.php typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php typo3/sysext/webhooks/Classes/Controller/ManagementController.php ``` Fixed via ``` git grep -l "#\[Controller\]" | grep Classes/ | xargs sed -i -e 's/#\[Controller\]/#[AsController]/' git grep -l 'Attribute\\Controller' | grep Classes/ | xargs sed -i -e 's/Attribute\\Controller/Attribute\\AsController/' ```
  8. Josef Glatz commented on patch set 2 CR +1 V +1 01/18/24, 12:58

    Reply

    Thank you for figuring that out!
  9. core-ci voted on patch set 2 V +1 01/18/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51752

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 01/18/24, 13:10

  11. Oli Bartsch merged patch set 3 01/18/24, 13:10