82507[BUGFIX] Restore `Controller` PHP attribute
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Josef Glatz +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Josef Glatz +1
- core-ci +1 CI
Issues 2
Files 57
- typo3/sysext/backend/Classes/Attribute/Controller.phpnew+33 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+2 −2
- typo3/sysext/backend/Classes/Controller/File/FileController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/MovePageController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/AboutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ClipboardController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+2 −2
Show 37 more files
- typo3/sysext/backend/Classes/Controller/DummyController.php+2 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ElementBrowserController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LinkController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+2 −2
- typo3/sysext/backend/Classes/Controller/LogoutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaController.php+2 −2
- typo3/sysext/backend/Classes/Controller/MfaSetupController.php+2 −2
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+2 −2
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/RecordListController.php+2 −2
- typo3/sysext/backend/Classes/Controller/RecordListDownloadController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+2 −2
- typo3/sysext/backend/Classes/Controller/ShortcutController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SwitchUserController.php+2 −2
- typo3/sysext/backend/Classes/Controller/SystemInformationController.php+2 −2
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php+2 −2
- typo3/sysext/backend/Migrations/Code/ClassAliasMap.php+0 −1
- typo3/sysext/backend/Migrations/Code/LegacyClassesForIde.php+0 −4
- typo3/sysext/reactions/Classes/Controller/ManagementController.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/AvailableSchedulerTasksController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/scheduler/Classes/Controller/SchedulerSetupCheckController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php+2 −2
- typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php+2 −2
- typo3/sysext/webhooks/Classes/Controller/ManagementController.php+2 −2
Review log 911
-
Oli Bartsch uploaded patch set 1 01/18/24, 10:26
-
core-ci voted on patch set 1 V +1 01/18/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51738
-
Andreas Kienast commented on patch set 1 CR -1 01/18/24, 10:37
Shouldn't this go into main as well? The old attribute is just deprecated there but the issue will remain the same. -
Oli Bartsch commented on patch set 1 01/18/24, 10:42
Reply
In v13, TYPO3 Core does not use the Controller attribute itself. -
Andreas Kienast voted on patch set 1 CR 0 01/18/24, 10:56
-
Benjamin Franzke uploaded patch set 2
V +101/18/24, 12:54 -
Benjamin Franzke commented on patch set 2 01/18/24, 12:54
Reply
Now I know what the issue in v12 is: We use the `#[Controller]` attribute in our *own* code (the change on `main` changed those), although it is deprecated. That caused the issue for Josef, despite no extension used the deprecated attribute. That means we should also switch these to to use `#[AsController]`: ``` git grep -l "#\[Controller\]" | grep Classes/ typo3/sysext/backend/Classes/Controller/AboutController.php typo3/sysext/backend/Classes/Controller/AjaxLoginController.php typo3/sysext/backend/Classes/Controller/BackendController.php typo3/sysext/backend/Classes/Controller/ClipboardController.php typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php typo3/sysext/backend/Classes/Controller/DummyController.php typo3/sysext/backend/Classes/Controller/EditDocumentController.php typo3/sysext/backend/Classes/Controller/ElementBrowserController.php typo3/sysext/backend/Classes/Controller/File/FileController.php typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php typo3/sysext/backend/Classes/Controller/FormSlugAjaxController.php typo3/sysext/backend/Classes/Controller/LinkController.php typo3/sysext/backend/Classes/Controller/LiveSearchController.php typo3/sysext/backend/Classes/Controller/LoginController.php typo3/sysext/backend/Classes/Controller/LogoutController.php typo3/sysext/backend/Classes/Controller/MfaAjaxController.php typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php typo3/sysext/backend/Classes/Controller/MfaController.php typo3/sysext/backend/Classes/Controller/MfaSetupController.php typo3/sysext/backend/Classes/Controller/NewRecordController.php typo3/sysext/backend/Classes/Controller/OnlineMediaController.php typo3/sysext/backend/Classes/Controller/Page/MovePageController.php typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php typo3/sysext/backend/Classes/Controller/PageLayoutController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigIncludesController.php typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigRecordsOverviewController.php typo3/sysext/backend/Classes/Controller/RecordListController.php typo3/sysext/backend/Classes/Controller/RecordListDownloadController.php typo3/sysext/backend/Classes/Controller/ResetPasswordController.php typo3/sysext/backend/Classes/Controller/Resource/ResourceController.php typo3/sysext/backend/Classes/Controller/Security/SudoModeController.php typo3/sysext/backend/Classes/Controller/ShortcutController.php typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php typo3/sysext/backend/Classes/Controller/SwitchUserController.php typo3/sysext/backend/Classes/Controller/SystemInformationController.php typo3/sysext/backend/Classes/Controller/Wizard/ImageManipulationController.php typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspAjaxController.php typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php typo3/sysext/reactions/Classes/Controller/ManagementController.php typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php typo3/sysext/tstemplate/Classes/Controller/ConstantEditorController.php typo3/sysext/tstemplate/Classes/Controller/InfoModifyController.php typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerController.php typo3/sysext/tstemplate/Classes/Controller/TemplateRecordsOverviewController.php typo3/sysext/webhooks/Classes/Controller/ManagementController.php ``` Fixed via ``` git grep -l "#\[Controller\]" | grep Classes/ | xargs sed -i -e 's/#\[Controller\]/#[AsController]/' git grep -l 'Attribute\\Controller' | grep Classes/ | xargs sed -i -e 's/Attribute\\Controller/Attribute\\AsController/' ``` -
Josef Glatz commented on patch set 2 CR +1 V +1 01/18/24, 12:58
Reply
Thank you for figuring that out! -
core-ci voted on patch set 2 V +1 01/18/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51752
-
Oli Bartsch voted on patch set 2 CR +2 V +2 01/18/24, 13:10
-
Oli Bartsch merged patch set 3 01/18/24, 13:10