82511[TASK] Doctrine DBAL 3.2 Connection::lastInsertId() mitigation
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 27
- typo3/sysext/backend/Classes/Command/CreateBackendUserCommand.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Database/Connection.php2+3 −5
- typo3/sysext/core/Classes/DataHandling/History/RecordHistoryStore.php+6 −6
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php+1 −1
- typo3/sysext/core/Classes/Resource/StorageRepository.php+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/lastInsertId.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Database/ConnectionTest.php5+17 −0
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/SaveToDatabaseFinisher.php+1 −1
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+1 −1
- typo3/sysext/install/Classes/Service/SetupService.php+2 −2
- typo3/sysext/redirects/Classes/Service/SlugService.php+1 −1
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInline1n.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineExpandsingle.php+1 −1
Show 7 more files
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombination.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTable.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableGroupField.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/General.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMn.php+2 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnGroup.php+2 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/InlineMnSymmetric.php+1 −1
Review log 1318
-
Stefan Bürk uploaded patch set 1 01/18/24, 12:11
-
Stefan Bürk wrote 01/18/24, 12:12
Topic set to doctrine-dbal -
core-ci voted on patch set 1 V -1 01/18/24, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51749
-
Stefan Bürk uploaded patch set 2
V -101/18/24, 12:17 -
Stefan Bürk uploaded patch set 3 01/18/24, 12:25
-
core-ci voted on patch set 2 V -1 01/18/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51750
-
core-ci voted on patch set 3 V +1 01/18/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51751
-
Stefan Bürk uploaded patch set 4
V +101/18/24, 14:41 -
core-ci voted on patch set 4 V +1 01/18/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51761
-
Oliver Klee voted on patch set 4 V +1 01/18/24, 14:57
-
Oliver Klee commented on patch set 4 01/18/24, 15:04
Connection.php:441```php @return numeric-string ```ConnectionTest.php:40``` public function lastInsertIdReturnsNextConsecutiveUid(): void ```ConnectionTest.php:51Let's check for the actual type instead: ```php self::assertSame('5', $connection->lastInsertId()); ``` -
Stefan Bürk uploaded patch set 5
V +101/18/24, 16:54 -
Stefan Bürk commented on patch set 5 01/18/24, 16:55
Connection.php:441ReplyDoneConnectionTest.php:40Reply"next" consecutive is technically wrong. If "5" is used (autoincrement) "6" would be the "next". Used `lastInsertIdReturnsExpectedConsecutiveUid` instead as name as a compromise. Fine for you ?ConnectionTest.php:51ReplyDone -
core-ci voted on patch set 5 V +1 01/18/24, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51771
-
Christian Kuhn commented on patch set 5 CR +1 V +1 01/18/24, 17:43
ConnectionTest.php:40ReplyDone -
Garvin Hicking voted on patch set 5 CR +1 V +1 01/18/24, 18:36
-
Stefan Bürk voted on patch set 5 CR +2 V +2 01/18/24, 18:42
-
Stefan Bürk merged patch set 6 01/18/24, 18:42