Review main Merged

82512[TASK] Ensure to provide `$type` argument for `Statement::bindValue()`

Stefan Bürk CR +2 V +2 Easy +10 −16 updated 01/18/24, 19:58

Commit message

The `$type` parameter for `Statement::bindValue()` will be
required with Doctrine DBAL 4.0 and usages in capsuled code
is now modified to always pass the argument as a preparation.

[1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-made-parameter-type-in-driver-level-statementbindvalue-required

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1320

  1. Stefan Bürk uploaded patch set 1 01/18/24, 12:59

  2. Stefan Bürk updated the commit message in patch set 2 01/18/24, 13:03

  3. core-ci voted on patch set 1 V +1 01/18/24, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51753

  4. Stefan Bürk wrote 01/18/24, 13:08

    Topic set to doctrine-dbal
  5. core-ci voted on patch set 2 V +1 01/18/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51754

  6. core-ci voted on patch set 1 V +1 01/18/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51755

  7. Stefan Bürk uploaded patch set 3 V +1 01/18/24, 14:41

  8. core-ci voted on patch set 3 V +1 01/18/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51762

  9. Oliver Klee voted on patch set 3 V +1 01/18/24, 14:57

  10. core-ci voted on patch set 3 V -1 01/18/24, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51764

  11. Oliver Klee voted on patch set 3 V 0 01/18/24, 15:15

  12. core-ci voted on patch set 3 V +1 01/18/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51764

  13. Stefan Bürk rebased onto patch set 4 V +1 01/18/24, 16:54

  14. Oliver Klee voted on patch set 3 V +1 01/18/24, 16:55

  15. core-ci voted on patch set 4 V +1 01/18/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51772

  16. Christian Kuhn voted on patch set 4 CR +1 V +1 01/18/24, 17:44

  17. Garvin Hicking commented on patch set 4 CR +1 V +1 01/18/24, 19:31

    I am a bit uncertain how the getUnique() thing will always operate as a bound "string" and not on columns with Ints. But if I read usages of it right it only affects filenames and the likes, I couldn't spot a different place, so it seems safe enough to me.
  18. Stefan Bürk commented on patch set 4 01/18/24, 19:50

    Reply

    Default was "string" already, like at all places. For low level it will be enforced to provide something (driver statement bindValue will only allow ParameterType enum with v4, in v3 its just a class and therefore a integer value passed). So, where currently the default kicks in we pass the default explictly further down. E.g. why I'm a fan to always provide even "default" values on method calls so that if a default changes or it is no longer optional it would not break - but with that I'm alone in the core)
  19. Stefan Bürk voted on patch set 4 CR +2 V +2 01/18/24, 19:58

  20. Stefan Bürk merged patch set 5 01/18/24, 19:58