Review main Merged

82520[BUGFIX] Typoscript ">" operator removes too much

Christian Kuhn CR +2 V +2 Normal +94 −4 updated 01/22/24, 12:23

Commit message

page = PAGE
page {
  10 = COA
  10 {
    10 = TEXT
    10.value = A
    20 = TEXT
    20.value = B
    30 = TEXT
    30.value = C
  }
}
page.10.30 >

This correctly unsets 'page.10.30', but also
'page.10.10' which should be kept of course.

The patch fixes this by avoiding a bogus
removeChildByName().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Christian Kuhn uploaded patch set 1 01/19/24, 22:28

  2. core-ci voted on patch set 1 V +1 01/19/24, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51832

  3. Christian Kuhn updated the commit message in patch set 2 V +1 01/20/24, 00:04

  4. core-ci voted on patch set 2 V +1 01/20/24, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51833

  5. Oliver Klee voted on patch set 2 V +1 01/20/24, 08:23

  6. Christian Kuhn updated the commit message in patch set 3 V +1 01/20/24, 09:12

  7. core-ci voted on patch set 3 V +1 01/20/24, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51839

  8. Georg Ringer voted on patch set 3 CR +1 01/20/24, 09:30

  9. Oliver Klee voted on patch set 3 V +1 01/20/24, 09:32

  10. Oliver Klee voted on patch set 3 CR +1 01/20/24, 09:32

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 01/20/24, 11:22

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 01/22/24, 12:23

  13. Christian Kuhn merged patch set 4 01/22/24, 12:23