Review main Merged Breaking

82525[!!!][TASK] Add native types to extbase Domain models

Oliver Klee CR +2 V +2 Normal +25 −67 updated 01/27/24, 18:39

Commit message

This change does not try to resolve the broken concept of
`AbstractFileFolder`, where subclasses provide more specific
return types for the `originalResource` property and other
code relies on that.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2127

Show 12 earlier messages
  1. Oliver Klee uploaded patch set 1 01/20/24, 16:35

  2. core-ci voted on patch set 1 V -1 01/20/24, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51845

  1. Oliver Klee uploaded patch set 2 V -1 01/21/24, 10:00

  2. core-ci voted on patch set 2 V -1 01/21/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51885

  3. Simon Schaufelberger commented on patch set 2 01/25/24, 14:24

    @typo3-coding@oliverklee.de Will this make it for v13?
  4. Simon Schaufelberger commented on patch set 2 01/26/24, 13:18

    Reply

    @typo3-coding@oliverklee.de for some reason this "improvement" actually causes a lot more trouble with phpstan...
  5. Oliver Klee commented on patch set 2 01/26/24, 13:32

    Reply

    Yes, this change needs some pre-patches to fix the mess with the `AbstractFileFolder` superclass
  6. Oliver Klee marked it work in progress 01/26/24, 16:02

  7. Oliver Klee uploaded patch set 3 V -1 01/27/24, 11:34

  8. Oliver Klee commented on patch set 2 01/27/24, 11:35

    This change is ready for review.

    Reply

    I have now worked around this using additional PHPDoc type annotations.
  9. Oliver Klee marked it ready for review 01/27/24, 11:35

  10. core-ci voted on patch set 3 V -1 01/27/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52286

  11. Oliver Klee uploaded patch set 4 V -1 01/27/24, 11:46

  12. Oliver Klee updated the commit message in patch set 5 01/27/24, 11:52

  13. core-ci voted on patch set 4 V +1 01/27/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52288

  14. core-ci voted on patch set 5 V +1 01/27/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52292

  15. Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/27/24, 12:35

  16. Oliver Klee uploaded patch set 6 CR +1 V +1 01/27/24, 12:50

  17. Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/27/24, 12:51

  18. Andreas Kienast commented on patch set 6 CR -1 01/27/24, 12:54

    File.php:28

    This looks superfluous now.

    FileReference.php:40

    This looks superfluous now.
  19. core-ci voted on patch set 6 V +1 01/27/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52294

  20. Oliver Klee commented on patch set 6 01/27/24, 13:30

    File.php:28 Reply

    No, it isn't (even though it would seem to be superfluous): The code using this class actually relies on the specific subtype of `ResourceInterface` being returned by instances of this class. This is a broken concept which I'd like to resolve in the future. This change here and https://review.typo3.org/c/Packages/TYPO3.CMS/+/82667 are pre-patches to that.

    FileReference.php:40 Reply

    The same here.
  21. Oliver Klee wrote 01/27/24, 13:32

    Topic set to extbase
  22. Oliver Klee commented on patch set 6 01/27/24, 17:12

    @a.fernandez@scripting-base.de Would you be willing to remove your -1?
  23. Andreas Kienast voted on patch set 6 CR 0 01/27/24, 17:21

  24. Christian Kuhn voted on patch set 6 CR +2 V +2 01/27/24, 18:39

  25. Christian Kuhn merged patch set 7 01/27/24, 18:39