82525[!!!][TASK] Add native types to extbase Domain models
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon+2 −7
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102632-UseStrictTypesInExtbase.rst+5 −0
- typo3/sysext/extbase/Classes/Domain/Model/AbstractFileFolder.php+3 −9
- typo3/sysext/extbase/Classes/Domain/Model/Category.php+10 −45
- typo3/sysext/extbase/Classes/Domain/Model/File.php2+2 −1
- typo3/sysext/extbase/Classes/Domain/Model/FileReference.php2+3 −5
Review log 2127
Show 12 earlier messages
-
Oliver Klee uploaded patch set 1 01/20/24, 16:35
-
core-ci voted on patch set 1 V -1 01/20/24, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51845
-
Oliver Klee uploaded patch set 2
V -101/21/24, 10:00 -
core-ci voted on patch set 2 V -1 01/21/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51885
-
Simon Schaufelberger commented on patch set 2 01/25/24, 14:24
@typo3-coding@oliverklee.de Will this make it for v13? -
Simon Schaufelberger commented on patch set 2 01/26/24, 13:18
Reply
@typo3-coding@oliverklee.de for some reason this "improvement" actually causes a lot more trouble with phpstan... -
Oliver Klee commented on patch set 2 01/26/24, 13:32
Reply
Yes, this change needs some pre-patches to fix the mess with the `AbstractFileFolder` superclass -
Oliver Klee marked it work in progress 01/26/24, 16:02
-
Oliver Klee uploaded patch set 3
V -101/27/24, 11:34 -
Oliver Klee commented on patch set 2 01/27/24, 11:35
This change is ready for review.Reply
I have now worked around this using additional PHPDoc type annotations. -
Oliver Klee marked it ready for review 01/27/24, 11:35
-
core-ci voted on patch set 3 V -1 01/27/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52286
-
Oliver Klee uploaded patch set 4
V -101/27/24, 11:46 -
Oliver Klee updated the commit message in patch set 5 01/27/24, 11:52
-
core-ci voted on patch set 4 V +1 01/27/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52288
-
core-ci voted on patch set 5 V +1 01/27/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52292
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/27/24, 12:35
-
Oliver Klee uploaded patch set 6
CR +1V +101/27/24, 12:50 -
Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/27/24, 12:51
-
Andreas Kienast commented on patch set 6 CR -1 01/27/24, 12:54
File.php:28This looks superfluous now.FileReference.php:40This looks superfluous now. -
core-ci voted on patch set 6 V +1 01/27/24, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52294
-
Oliver Klee commented on patch set 6 01/27/24, 13:30
File.php:28ReplyNo, it isn't (even though it would seem to be superfluous): The code using this class actually relies on the specific subtype of `ResourceInterface` being returned by instances of this class. This is a broken concept which I'd like to resolve in the future. This change here and https://review.typo3.org/c/Packages/TYPO3.CMS/+/82667 are pre-patches to that.FileReference.php:40ReplyThe same here. -
Oliver Klee wrote 01/27/24, 13:32
Topic set to extbase -
Oliver Klee commented on patch set 6 01/27/24, 17:12
@a.fernandez@scripting-base.de Would you be willing to remove your -1? -
Andreas Kienast voted on patch set 6 CR 0 01/27/24, 17:21
-
Christian Kuhn voted on patch set 6 CR +2 V +2 01/27/24, 18:39
-
Christian Kuhn merged patch set 7 01/27/24, 18:39