Review main Merged

82532[TASK] Drop the `AbstractFileFolder` superclass

Oliver Klee CR +2 V +2 Normal +38 −71 updated 01/27/24, 21:03

Commit message

This internal superclass provided methods with types that were
overwritten with a different signature in subclasses, which means
that the abstraction wass not helpful (and prevented using proper
native type declarations). The superclass is hence now dropped.

As the dropped class had been marked as `@internal`, this change
is not breaking.

The `AbstractFileFolderConverter` needs some more cleanup, but
that is out of scope for this change.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1319

  1. Oliver Klee uploaded patch set 1 01/21/24, 10:17

  2. Oliver Klee uploaded patch set 2 01/21/24, 10:19

  3. core-ci voted on patch set 1 V -1 01/21/24, 10:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51886

  4. core-ci voted on patch set 2 V -1 01/21/24, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51887

  5. Oliver Klee uploaded patch set 3 V -1 01/27/24, 18:51

  6. core-ci voted on patch set 3 V -1 01/27/24, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52318

  7. Oliver Klee uploaded patch set 4 V -1 01/27/24, 19:49

  8. core-ci voted on patch set 4 V -1 01/27/24, 19:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52323

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 01/27/24, 19:56

  10. Christian Kuhn voted on patch set 4 CR 0 V 0 01/27/24, 19:59

  11. Oliver Klee uploaded patch set 5 V -1 01/27/24, 20:00

  12. Oliver Klee commented on patch set 5 CR -1 01/27/24, 20:02

    Folder.php:26

    I think this then needs to be `Folder`. On it.
  13. Oliver Klee uploaded patch set 6 CR -1 01/27/24, 20:06

  14. core-ci voted on patch set 5 V +1 01/27/24, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52325

  15. Oliver Klee commented on patch set 6 01/27/24, 20:08

    Folder.php:26 Reply

    Done. This has introduced a new (valid) PHPStan warning about a problem that had been there all along. I've added #102961 for this.
  16. core-ci voted on patch set 6 V +1 01/27/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52326

  17. Christian Kuhn voted on patch set 6 CR +1 V +1 01/27/24, 20:32

  18. Stefan Bürk voted on patch set 6 CR +2 V +2 01/27/24, 21:03

  19. Stefan Bürk merged patch set 7 01/27/24, 21:03