82535[!!!][TASK] Add more native types in Extbase annotation classes
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102632-UseStrictTypesInExtbase.rstnew+89 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102632-UseStrictTypesInExtbaseActionController.rstdeleted+0 −78
- typo3/sysext/extbase/Classes/Annotation/ORM/Cascade.php+2 −2
- typo3/sysext/extbase/Classes/Annotation/IgnoreValidation.php+1 −1
- typo3/sysext/extbase/Classes/Annotation/Validate.php3+4 −11
Review log 2332
Show 47 earlier messages
-
Oliver Klee uploaded patch set 1 01/21/24, 18:12
-
Oliver Klee updated the commit message in patch set 2 01/21/24, 18:12
-
Oliver Klee updated the commit message in patch set 3 01/21/24, 18:12
-
core-ci voted on patch set 1 V +1 01/21/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51896
-
core-ci voted on patch set 2 V +1 01/21/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51897
-
core-ci voted on patch set 3 V +1 01/21/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51898
-
Oliver Klee commented on patch set 3 CR -1 01/21/24, 20:25
I'll need to fix one more array shape.
-
Oliver Klee uploaded patch set 4
CR -1V +101/23/24, 16:25 -
Oliver Klee uploaded patch set 5 01/23/24, 16:27
-
core-ci voted on patch set 5 V +1 01/23/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52017
-
core-ci voted on patch set 4 V +1 01/23/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52016
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/25/24, 14:15
-
Benni Mack commented on patch set 5 01/25/24, 14:22
Validate.php:63should we include the stringable interface as well here? -
Oliver Klee commented on patch set 5 01/25/24, 14:35
Validate.php:63ReplyI'm not very familiar with the `Stringable` interface. What would be the benefit of adding it here? -
Oliver Klee commented on patch set 5 01/25/24, 14:41
Validate.php:63ReplyAh, we can add it to the class. Yes, I'd like to do that, but in a separate change, if that's okay with you. -
Benni Mack commented on patch set 5 CR -1 01/25/24, 15:09
if this is breaking, it needs a RST -
Andreas Kienast commented on patch set 5 CR -1 01/26/24, 07:50
I honestly fail to see the reasoning why this patch is breaking. This is "consumer API", nothing designed to be extensible, IMO. -
Oliver Klee uploaded patch set 6
CR +1V +101/26/24, 12:09 -
Oliver Klee commented on patch set 6 01/26/24, 12:09
Reply
Done.Reply
Just to be sure, I've added the breaking ReST. -
Oliver Klee uploaded patch set 7 01/26/24, 12:10
-
core-ci voted on patch set 6 V +1 01/26/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52243
-
core-ci voted on patch set 7 V +1 01/26/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52245
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/26/24, 12:19
-
Nikita Hovratov uploaded patch set 8
CR +1V +101/26/24, 17:48 -
Nikita Hovratov voted on patch set 8 CR +1 01/26/24, 17:48
-
core-ci voted on patch set 8 V +1 01/26/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52266
-
Christian Kuhn updated the commit message in patch set 9
CR +1V +101/26/24, 18:41 -
Christian Kuhn voted on patch set 9 CR +1 V +1 01/26/24, 18:42
-
Simon Schaufelberger voted on patch set 9 CR +1 V +1 01/26/24, 18:44
-
core-ci voted on patch set 9 V +1 01/26/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52269
-
Nikita Hovratov voted on patch set 9 CR +2 V +2 01/26/24, 18:49
-
Nikita Hovratov merged patch set 10 01/26/24, 18:49