Review main Merged Breaking

82535[!!!][TASK] Add more native types in Extbase annotation classes

Oliver Klee CR +2 V +2 Normal +96 −92 updated 01/26/24, 18:49

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 2332

Show 47 earlier messages
  1. Oliver Klee uploaded patch set 1 01/21/24, 18:12

  2. Oliver Klee updated the commit message in patch set 2 01/21/24, 18:12

  3. Oliver Klee updated the commit message in patch set 3 01/21/24, 18:12

  4. core-ci voted on patch set 1 V +1 01/21/24, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51896

  5. core-ci voted on patch set 2 V +1 01/21/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51897

  6. core-ci voted on patch set 3 V +1 01/21/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51898

  7. Oliver Klee commented on patch set 3 CR -1 01/21/24, 20:25

    I'll need to fix one more array shape.
  1. Oliver Klee uploaded patch set 4 CR -1 V +1 01/23/24, 16:25

  2. Oliver Klee uploaded patch set 5 01/23/24, 16:27

  3. core-ci voted on patch set 5 V +1 01/23/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52017

  4. core-ci voted on patch set 4 V +1 01/23/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52016

  5. Simon Schaufelberger voted on patch set 5 CR +1 V +1 01/25/24, 14:15

  6. Benni Mack commented on patch set 5 01/25/24, 14:22

    Validate.php:63

    should we include the stringable interface as well here?
  7. Oliver Klee commented on patch set 5 01/25/24, 14:35

    Validate.php:63 Reply

    I'm not very familiar with the `Stringable` interface. What would be the benefit of adding it here?
  8. Oliver Klee commented on patch set 5 01/25/24, 14:41

    Validate.php:63 Reply

    Ah, we can add it to the class. Yes, I'd like to do that, but in a separate change, if that's okay with you.
  9. Benni Mack commented on patch set 5 CR -1 01/25/24, 15:09

    if this is breaking, it needs a RST
  10. Andreas Kienast commented on patch set 5 CR -1 01/26/24, 07:50

    I honestly fail to see the reasoning why this patch is breaking. This is "consumer API", nothing designed to be extensible, IMO.
  11. Oliver Klee uploaded patch set 6 CR +1 V +1 01/26/24, 12:09

  12. Oliver Klee commented on patch set 6 01/26/24, 12:09

    Reply

    Done.

    Reply

    Just to be sure, I've added the breaking ReST.
  13. Oliver Klee uploaded patch set 7 01/26/24, 12:10

  14. core-ci voted on patch set 6 V +1 01/26/24, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52243

  15. core-ci voted on patch set 7 V +1 01/26/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52245

  16. Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/26/24, 12:19

  17. Nikita Hovratov uploaded patch set 8 CR +1 V +1 01/26/24, 17:48

  18. Nikita Hovratov voted on patch set 8 CR +1 01/26/24, 17:48

  19. core-ci voted on patch set 8 V +1 01/26/24, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52266

  20. Christian Kuhn updated the commit message in patch set 9 CR +1 V +1 01/26/24, 18:41

  21. Christian Kuhn voted on patch set 9 CR +1 V +1 01/26/24, 18:42

  22. Simon Schaufelberger voted on patch set 9 CR +1 V +1 01/26/24, 18:44

  23. core-ci voted on patch set 9 V +1 01/26/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52269

  24. Nikita Hovratov voted on patch set 9 CR +2 V +2 01/26/24, 18:49

  25. Nikita Hovratov merged patch set 10 01/26/24, 18:49