Review main Merged

82556[BUGFIX] Fix type annotations in extbase Annotation classes

Oliver Klee CR +2 V +2 Easy +5 −3 updated 01/23/24, 15:08

Commit message

This change makes the parameter type annotations consistent with
the property type annotations in the affected classes.

This allows PHPStan to catch calls with invalid argument types.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Oliver Klee uploaded patch set 1 01/22/24, 11:06

  2. core-ci voted on patch set 1 V +1 01/22/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51921

  3. Oliver Klee uploaded patch set 2 V +1 01/22/24, 16:19

  4. core-ci voted on patch set 2 V +1 01/22/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51945

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 01/23/24, 15:08

  6. Christian Kuhn merged patch set 3 01/23/24, 15:08