82598[TASK] IndexedSearch: Extract enum-esque structs into real enums
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+54 −56
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+34 −54
- typo3/sysext/indexed_search/Classes/Type/DefaultOperand.phpnew+27 −0
- typo3/sysext/indexed_search/Classes/Type/GroupOption.phpnew+27 −0
- typo3/sysext/indexed_search/Classes/Type/IndexingConfiguration.phpnew+28 −0
- typo3/sysext/indexed_search/Classes/Type/MediaType.phpnew+28 −0
- typo3/sysext/indexed_search/Classes/Type/SearchType.phpnew+31 −0
- typo3/sysext/indexed_search/Classes/Type/SectionType.phpnew+29 −0
Review log 710
-
Andreas Kienast uploaded patch set 1 01/23/24, 11:32
-
core-ci voted on patch set 1 V -1 01/23/24, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51989
-
Andreas Kienast uploaded patch set 2
V -101/23/24, 11:41 -
core-ci voted on patch set 2 V +1 01/23/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51990
-
Andreas Kienast uploaded patch set 3
V +101/23/24, 12:05 -
Christian Kuhn voted on patch set 3 CR +1 V +1 01/23/24, 12:10
-
core-ci voted on patch set 3 V +1 01/23/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51992
-
Stefan Bürk voted on patch set 3 CR +1 V +1 01/23/24, 12:11
-
Andreas Kienast voted on patch set 3 CR +2 V +2 01/23/24, 12:13
-
Andreas Kienast merged patch set 4 01/23/24, 12:13