Review main Merged

82598[TASK] IndexedSearch: Extract enum-esque structs into real enums

Andreas Kienast CR +2 V +2 Hard +258 −110 updated 01/23/24, 12:13

Commit message

IndexedSearch uses a bunch of "randomly" defined values for options that
are hard to read and understand in the code flow. To improve the
situation a bit, such structs are now converted into real PHP enums,
providing assistance when reading and/or refactoring code.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 710

  1. Andreas Kienast uploaded patch set 1 01/23/24, 11:32

  2. core-ci voted on patch set 1 V -1 01/23/24, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51989

  3. Andreas Kienast uploaded patch set 2 V -1 01/23/24, 11:41

  4. core-ci voted on patch set 2 V +1 01/23/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51990

  5. Andreas Kienast uploaded patch set 3 V +1 01/23/24, 12:05

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 01/23/24, 12:10

  7. core-ci voted on patch set 3 V +1 01/23/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51992

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 01/23/24, 12:11

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 01/23/24, 12:13

  10. Andreas Kienast merged patch set 4 01/23/24, 12:13