Review 12.4 Merged

82616[BUGFIX] Do not resolve resource paths in EXT:form

Peter Kraume CR +2 V +2 Normal +6 −93 updated 01/25/24, 11:54

Commit message

The method resolveResourcePaths() is superfluous because the
PageRenderer resolves path with EXT: later with
getStreamlinedFileName() anyway.
Furthermore this patch resolves open_basedir errors. As a plus,
the form.css gets a version numbered filename now which mitigates
caching issues.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 89

  1. Peter Kraume commented on patch set 1 01/25/24, 10:44

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Controller/FormManagerController.php
  2. Peter Kraume abandoned the change 01/25/24, 10:49

  3. Peter Kraume restored the change 01/25/24, 11:00

  4. Peter Kraume uploaded patch set 2 01/25/24, 11:00

  5. Peter Kraume marked it ready for review 01/25/24, 11:01

  6. core-ci voted on patch set 2 V +1 01/25/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52154

  7. Oliver Hader voted on patch set 2 CR +1 V +1 01/25/24, 11:40

  8. Oliver Hader voted on patch set 2 CR +2 V +2 01/25/24, 11:54

  9. Oliver Hader merged patch set 3 01/25/24, 11:54