Review main Merged

82632[TASK] Indexed Search: Introduce strict types

Andreas Kienast CR +2 V +2 Hard +262 −557 updated 01/24/24, 15:38

Commit message

This patch adds PHP types to all properties and methods within
EXT:indexed_search.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1118

  1. Andreas Kienast uploaded patch set 1 01/24/24, 11:50

  2. core-ci voted on patch set 1 V -1 01/24/24, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52070

  3. Andreas Kienast uploaded patch set 2 V -1 01/24/24, 12:00

  4. Andreas Kienast uploaded patch set 3 01/24/24, 12:05

  5. core-ci voted on patch set 2 V -1 01/24/24, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52072

  6. core-ci voted on patch set 3 V -1 01/24/24, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52073

  7. Andreas Kienast uploaded patch set 4 V -1 01/24/24, 13:18

  8. core-ci voted on patch set 4 V -1 01/24/24, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52080

  9. Andreas Kienast uploaded patch set 5 V -1 01/24/24, 14:03

  10. core-ci voted on patch set 5 V -1 01/24/24, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52082

  11. Andreas Kienast uploaded patch set 6 V -1 01/24/24, 14:57

  12. core-ci voted on patch set 6 V -1 01/24/24, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52086

  13. Andreas Kienast uploaded patch set 7 V -1 01/24/24, 15:22

  14. core-ci voted on patch set 7 V +1 01/24/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52089

  15. Benni Mack voted on patch set 7 CR +1 V +1 01/24/24, 15:30

  16. Christian Kuhn commented on patch set 7 01/24/24, 15:36

    IndexSearchRepository.php:1154

    i actually prefer ?? false in those cases to not make php cast null to bool again, but never mind ;)
  17. Christian Kuhn voted on patch set 7 CR +2 V +2 01/24/24, 15:38

  18. Christian Kuhn merged patch set 8 01/24/24, 15:38