Review main Merged Breaking

82636[!!!][TASK] Remove `ExpressionBuilder::trim()` deprecation

Stefan Bürk CR +2 V +2 Normal +63 −24 updated 01/25/24, 07:49

Commit message

With #102875 Doctrine DBAL 4.x has been added which was a
task over a longer time. Originally planned to deprecate
changes the later decision was to pass Doctrine breaking
changes directly.

It has been missed to remove the `ExpressionBuilder::trim()`
deprecation for the integer TrimMode and the mitigation for
it.

This change now removes the deprecation and directly allows
only the Doctrine DBAL TrimMode enum.

[1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-converted-enum-like-classes-to-enums

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 911

  1. Stefan Bürk uploaded patch set 1 01/24/24, 21:26

  2. Stefan Bürk wrote 01/24/24, 21:27

    Topic set to doctrine-dbal
  3. core-ci voted on patch set 1 V +1 01/24/24, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52112

  4. Nikita Hovratov uploaded patch set 2 V +1 01/24/24, 22:07

  5. core-ci voted on patch set 2 V +1 01/24/24, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52114

  6. Nikita Hovratov voted on patch set 2 CR +1 01/24/24, 22:15

  7. Oliver Klee voted on patch set 2 CR +1 V +1 01/24/24, 22:29

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 01/25/24, 06:33

  9. Benni Mack voted on patch set 2 CR +1 V +1 01/25/24, 07:43

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 01/25/24, 07:49

  11. Stefan Bürk merged patch set 3 01/25/24, 07:49