Review main Merged

82637[BUGFIX] Ensure database connection port is integer

Nikita Hovratov CR +2 V +2 Easy +5 −0 updated 01/24/24, 22:42

Commit message

It's possible the port is provided as a string. This has to be taken
care for before handed over to doctrine/dbal as it is strictly typed
and doesn't do type casting on its own.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Nikita Hovratov uploaded patch set 1 01/24/24, 21:57

  2. core-ci voted on patch set 1 V +1 01/24/24, 22:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52113

  3. Oliver Klee voted on patch set 1 CR +1 01/24/24, 22:29

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/24/24, 22:31

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 01/24/24, 22:42

  6. Oli Bartsch merged patch set 2 01/24/24, 22:42