Review main Merged Breaking

82639[!!!][TASK] Remove `ExpressionBuilder::QUOTE_*` constants

Stefan Bürk CR +2 V +2 Easy +9 −5 updated 01/25/24, 10:31

Commit message

The `ExpressionBUilder::QUOTE_*` class constants are
unused already with TYPO3 v12 and `Doctrine DBAL 3.x`
and do not serve any purpose anymore.

This change removes them now to keep the house clean.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 812

  1. Stefan Bürk uploaded patch set 1 01/24/24, 22:42

  2. Stefan Bürk uploaded patch set 2 01/24/24, 22:46

  3. core-ci voted on patch set 1 V +1 01/24/24, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52116

  4. core-ci voted on patch set 2 V +1 01/24/24, 22:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52117

  5. Stefan Bürk uploaded patch set 3 V +1 01/24/24, 22:55

  6. core-ci voted on patch set 3 V +1 01/24/24, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52118

  7. Stefan Bürk rebased onto patch set 4 V +1 01/25/24, 07:55

  8. core-ci voted on patch set 4 V +1 01/25/24, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52133

  9. Oliver Klee voted on patch set 4 CR +1 V +1 01/25/24, 08:54

  10. Oli Bartsch voted on patch set 4 CR +1 V +1 01/25/24, 10:01

  11. Stefan Bürk voted on patch set 4 CR +2 V +2 01/25/24, 10:31

  12. Stefan Bürk merged patch set 5 01/25/24, 10:31