Review main Merged

82643[TASK] Indexed Search: remove `milliseconds()` helper method

Andreas Kienast CR +2 V +2 Easy +12 −12 updated 01/25/24, 10:22

Commit message

This patch removes the static `IndexedSearchUtility::milliseconds()`
method, which is used a few times only.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Andreas Kienast uploaded patch set 1 01/25/24, 09:49

  2. core-ci voted on patch set 1 V +1 01/25/24, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52146

  3. Benni Mack uploaded patch set 2 V +1 01/25/24, 09:57

  4. core-ci voted on patch set 2 V -1 01/25/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52147

  5. Andreas Kienast uploaded patch set 3 V -1 01/25/24, 10:04

  6. Oli Bartsch voted on patch set 3 CR +1 V +1 01/25/24, 10:05

  7. core-ci voted on patch set 3 V +1 01/25/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52148

  8. Benni Mack voted on patch set 3 CR +1 V +1 01/25/24, 10:18

  9. Andreas Kienast voted on patch set 3 CR +2 V +2 01/25/24, 10:22

  10. Andreas Kienast merged patch set 4 01/25/24, 10:22