82644[TASK] Do not use Extbase for querying sys_log
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 9
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+3 −4
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php3+30 −87
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+57 −48
- typo3/sysext/belog/Configuration/Extbase/Persistence/Classes.phpdeleted+0 −41
- typo3/sysext/belog/Tests/Unit/Domain/Repository/LogEntryRepositoryTest.phpdeleted+0 −41
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −2
- typo3/sysext/core/Configuration/TCA/sys_log.phpdeleted+0 −122
- typo3/sysext/core/ext_tables.sql2+9 −5
Review log 1521
-
Benni Mack uploaded patch set 1 01/25/24, 11:05
-
Mathias Brodala commented on patch set 1 01/25/24, 11:09
-
Benni Mack commented on patch set 1 01/25/24, 11:12
LogEntry.php:240ReplyNo, it's the other around. // The folloving lines are doing the same $this->request->data['comments']['user_id'] = $this->request->data['comments']['user_id'] ?? 'value'; // Instead of repeating variables with long names, the equal coalesce operator is used $this->request->data['comments']['user_id'] ??= 'value'; -
core-ci voted on patch set 1 V -1 01/25/24, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52156
-
Mathias Brodala commented on patch set 1 01/25/24, 11:15
LogEntry.php:240ReplyAh, indeed, one would need to "fill" the $row with $obj values, then this operator could be used. -
Benni Mack uploaded patch set 2
V -101/25/24, 11:58 -
core-ci voted on patch set 2 V -1 01/25/24, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52170
-
Benni Mack uploaded patch set 3
V -101/25/24, 13:23 -
core-ci voted on patch set 3 V -1 01/25/24, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52180
-
Benni Mack uploaded patch set 4
V -101/25/24, 15:21 -
Benni Mack updated the commit message in patch set 5 01/25/24, 15:23
-
core-ci voted on patch set 4 V +1 01/25/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52187
-
core-ci voted on patch set 5 V +1 01/25/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52188
-
Simon Schaufelberger commented on patch set 5 01/25/24, 15:34
ext_tables.sql:311the last comma should be removed to have valid sql, or? -
Benni Mack commented on patch set 6
V +101/25/24, 15:52Published edit on patch set 5. -
Benni Mack commented on patch set 6 01/25/24, 15:53
ext_tables.sql:311ReplyDone -
core-ci voted on patch set 6 V +1 01/25/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52192
-
Christian Kuhn voted on patch set 6 CR +1 V +1 01/25/24, 18:40
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/25/24, 21:09
-
Benni Mack voted on patch set 6 CR +2 V +2 01/25/24, 22:16
-
Benni Mack merged patch set 7 01/25/24, 22:16
LogEntry.php:240