Review main Merged

82644[TASK] Do not use Extbase for querying sys_log

Benni Mack CR +2 V +2 Hard +100 −355 updated 01/25/24, 22:16

Commit message

The only reason why there is TCA
for sys_log is that EXT:belog can use Extbase
to query records.

The change now uses a custom Repository
without Extbase while keeping the model
architecture, effectively allowing us
to remove the TCA entry for sys_log.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1521

  1. Benni Mack uploaded patch set 1 01/25/24, 11:05

  2. Mathias Brodala commented on patch set 1 01/25/24, 11:09

    LogEntry.php:240

    This can be simplified: $obj->uid ??= $row['uid'] See https://wiki.php.net/rfc/null_coalesce_equal_operator
  3. Benni Mack commented on patch set 1 01/25/24, 11:12

    LogEntry.php:240 Reply

    No, it's the other around. // The folloving lines are doing the same $this->request->data['comments']['user_id'] = $this->request->data['comments']['user_id'] ?? 'value'; // Instead of repeating variables with long names, the equal coalesce operator is used $this->request->data['comments']['user_id'] ??= 'value';
  4. core-ci voted on patch set 1 V -1 01/25/24, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52156

  5. Mathias Brodala commented on patch set 1 01/25/24, 11:15

    LogEntry.php:240 Reply

    Ah, indeed, one would need to "fill" the $row with $obj values, then this operator could be used.
  6. Benni Mack uploaded patch set 2 V -1 01/25/24, 11:58

  7. core-ci voted on patch set 2 V -1 01/25/24, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52170

  8. Benni Mack uploaded patch set 3 V -1 01/25/24, 13:23

  9. core-ci voted on patch set 3 V -1 01/25/24, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52180

  10. Benni Mack uploaded patch set 4 V -1 01/25/24, 15:21

  11. Benni Mack updated the commit message in patch set 5 01/25/24, 15:23

  12. core-ci voted on patch set 4 V +1 01/25/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52187

  13. core-ci voted on patch set 5 V +1 01/25/24, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52188

  14. Simon Schaufelberger commented on patch set 5 01/25/24, 15:34

    ext_tables.sql:311

    the last comma should be removed to have valid sql, or?
  15. Benni Mack commented on patch set 6 V +1 01/25/24, 15:52

    Published edit on patch set 5.
  16. Benni Mack commented on patch set 6 01/25/24, 15:53

    ext_tables.sql:311 Reply

    Done
  17. core-ci voted on patch set 6 V +1 01/25/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52192

  18. Christian Kuhn voted on patch set 6 CR +1 V +1 01/25/24, 18:40

  19. Simon Schaufelberger voted on patch set 6 CR +1 V +1 01/25/24, 21:09

  20. Benni Mack voted on patch set 6 CR +2 V +2 01/25/24, 22:16

  21. Benni Mack merged patch set 7 01/25/24, 22:16