Review main Merged

82647[TASK] Use cleaner check for MySQL fulltext in search

Benni Mack CR +2 V +2 Hard +132 −227 updated 01/25/24, 18:35

Commit message

When activating mysql fulltext,
the DB tables "index_rel" and "index_words"
are not needed. This change makes
readability a lot easier, by avoiding
many unneeded checks.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Benni Mack uploaded patch set 1 01/25/24, 11:39

  2. Benni Mack uploaded patch set 2 01/25/24, 11:39

  3. core-ci voted on patch set 1 V -1 01/25/24, 11:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52164

  4. Christian Kuhn commented on patch set 2 01/25/24, 11:45

    IndexedSearchUtility.php:163

    could we make this non-static and inject the ExtensionConfiguration dependency?
  5. core-ci voted on patch set 2 V +1 01/25/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52165

  6. Benni Mack commented on patch set 2 01/25/24, 11:53

    IndexedSearchUtility.php:163 Reply

    Currently I see this as an in-between solution, once we are done with the major cleanups, we could use the Repositories and Controllers to use DI and inject the information then directly. The Utility is internal anyways and will hopefully vanish once we go into smaller PHP classes. these are all monsters.
  7. Benni Mack uploaded patch set 3 V +1 01/25/24, 12:37

  8. core-ci voted on patch set 3 V -1 01/25/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52173

  9. Benni Mack uploaded patch set 4 V -1 01/25/24, 13:10

  10. core-ci voted on patch set 4 V +1 01/25/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52177

  11. Stefan Bürk commented on patch set 4 CR +1 V +1 01/25/24, 13:27

    IndexedSearchUtility.php:163 Reply

    Albeit basically on lolli's track, I'm fine with a intermediate solution for now - and as a intermediate `understanding` change for a eventually more deeper refactoring.
  12. Benni Mack commented on patch set 4 01/25/24, 15:27

    IndexedSearchUtility.php:163 Reply

    I am also lolli's track, but I prefer to do this at a later stage.
  13. Jochen Roth voted on patch set 4 CR +1 V +1 01/25/24, 16:49

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 01/25/24, 18:35

  15. Christian Kuhn merged patch set 5 01/25/24, 18:35