Review main Merged

82652[TASK] Indexed Search: Remove `searchData` property

Andreas Kienast CR +2 V +2 Easy +17 −19 updated 01/26/24, 11:19

Commit message

The `searchData` property is now removed to get rid of some state in the
`SearchController` class.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Andreas Kienast uploaded patch set 1 01/26/24, 08:56

  2. Andreas Kienast commented on patch set 1 01/26/24, 08:57

    `$this->searchWords` will be handled in a separate patch.
  3. core-ci voted on patch set 1 V +1 01/26/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52217

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 01/26/24, 09:10

  5. Simon Schaufelberger voted on patch set 1 CR +1 01/26/24, 09:12

  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 01/26/24, 09:17

  7. core-ci voted on patch set 2 V +1 01/26/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52218

  8. Andreas Kienast commented on patch set 2 CR -2 01/26/24, 09:24

    Will remove the hooks first
  9. Andreas Kienast uploaded patch set 3 V +1 01/26/24, 10:15

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. Andreas Kienast voted on patch set 3 CR 0 01/26/24, 10:16

  11. core-ci voted on patch set 3 V +1 01/26/24, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52227

  12. Oliver Klee voted on patch set 3 CR +1 01/26/24, 10:42

  13. Benni Mack voted on patch set 3 CR +1 V +1 01/26/24, 10:57

  14. Andreas Kienast voted on patch set 3 CR +2 V +2 01/26/24, 11:19

  15. Andreas Kienast merged patch set 4 01/26/24, 11:19