82666[!!!][TASK] Deprecate and replace extbase HashService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102763-ExtbaseHashServiceUsageReplacedWithCoreHashService.rst4new+48 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102763-FrontendUserPasswordRecoveryHashesInvalidated.rst2new+44 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Deprecation-102763-ExtbaseHashService.rst2new+68 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php2+4 −3
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+7 −11
- typo3/sysext/extbase/Classes/Security/Cryptography/HashService.php+26 −7
- typo3/sysext/extbase/Classes/Security/HashScope.phpnew+34 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+5 −9
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+14 −16
- typo3/sysext/extbase/Tests/UnitDeprecated/Cryptography/HashServiceTest.phprenamed+3 −2
- typo3/sysext/felogin/Classes/Configuration/RecoveryConfiguration.php+2 −2
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php+6 −6
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+5 −10
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+4 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+3 −3
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime/FormSession.php+6 −6
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+5 −5
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+5 −4
- typo3/sysext/form/Classes/Security/HashScope.phpnew+34 −0
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+3 −2
Review log 2135
Show 510 earlier messages
-
Torben Hansen uploaded patch set 1 01/27/24, 06:48
-
core-ci voted on patch set 1 V -1 01/27/24, 06:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52282
-
Torben Hansen uploaded patch set 2
V -101/27/24, 11:30 -
core-ci voted on patch set 2 V +1 01/27/24, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52285
-
Torben Hansen uploaded patch set 3
V +101/27/24, 13:47 -
Torben Hansen uploaded patch set 4 01/27/24, 13:49
-
core-ci voted on patch set 3 V -1 01/27/24, 13:53 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 4 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52300
-
core-ci voted on patch set 4 V -1 01/27/24, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52301
-
Torben Hansen uploaded patch set 5
V -101/27/24, 14:04 -
core-ci voted on patch set 5 V +1 01/27/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52302
-
Torben Hansen uploaded patch set 6
V +101/27/24, 17:30 -
core-ci voted on patch set 6 V +1 01/27/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52307
-
Garvin Hicking commented on patch set 6 01/27/24, 17:41
some doc remarks, no code reviewBreaking-102763-ExtbaseHashServiceUsageReplacedWithCoreHashService.rst:16"replaced by"Breaking-102763-ExtbaseHashServiceUsageReplacedWithCoreHashService.rst:34"of the", copypastaBreaking-102763-FrontendUserPasswordRecoveryHashesInvalidated.rst:24+ "These hashes have a limited lifetime already (12 hours). On large installations that require the hashes to survive a major update, you could write a small CLI task that re-adds missing hashes created in the maintenance time window of the upgrade." (may need rephrasing, just an idea to get people unannoyed.)Deprecation-102763-ExtbaseHashService.rst:15"in favor of" instead "favor to". -
Christian Kuhn commented on patch set 6 01/27/24, 18:33
Breaking-102763-ExtbaseHashServiceUsageReplacedWithCoreHashService.rst:16ReplyDoneBreaking-102763-ExtbaseHashServiceUsageReplacedWithCoreHashService.rst:34ReplyDoneBreaking-102763-FrontendUserPasswordRecoveryHashesInvalidated.rst:24ReplyDoneDeprecation-102763-ExtbaseHashService.rst:15ReplyDone -
Christian Kuhn uploaded patch set 7
V +101/27/24, 18:35 -
core-ci voted on patch set 7 V +1 01/27/24, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52313
-
Oliver Hader commented on patch set 7 01/28/24, 17:07
ActionController.php:586It feels like this should be more specific (containing an "extbase"-reference) and organized in a constant or enum... -
Oliver Hader uploaded patch set 8
V +101/28/24, 17:31 -
core-ci voted on patch set 8 V -1 01/28/24, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52373
-
Oliver Hader uploaded patch set 9
V -101/28/24, 17:38 -
core-ci voted on patch set 9 V -1 01/28/24, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52374
-
Oliver Hader uploaded patch set 10
V -101/28/24, 17:50 -
core-ci voted on patch set 10 V -1 01/28/24, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52375
-
Oliver Hader uploaded patch set 11
V -101/28/24, 18:06 -
core-ci voted on patch set 11 V -1 01/28/24, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52379
-
Oliver Hader uploaded patch set 12
V -101/28/24, 18:08 -
core-ci voted on patch set 12 V -1 01/28/24, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52380
-
Oliver Hader uploaded patch set 13
V -101/28/24, 18:15 -
Oliver Hader commented on patch set 13 01/28/24, 18:17
I changed the existing `HashService` breaking now as well - basically enforcing a generic pepper for Extbase apps, still using the old service. Code-wise it's the same. But those HMACs now have a pepper (which was the initial goal of this whole refactoring) → thus, existing hashes won't work anymore and have to be regenerated (clear cache & reload the form).ActionController.php:586ReplyDone -
core-ci voted on patch set 13 V -1 01/28/24, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52381
-
Oliver Hader uploaded patch set 14
V -101/28/24, 18:33 -
Oliver Hader voted on patch set 14 CR +1 V +1 01/28/24, 18:36
-
core-ci voted on patch set 14 V +1 01/28/24, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52382
-
Benni Mack voted on patch set 14 CR +2 V +2 01/28/24, 20:08
-
Benni Mack merged patch set 15 01/28/24, 20:08